Skip to content

Commit a93d90f

Browse files
committed
make sure all functions in sfp_opte_base.py are good to be called
1 parent add1040 commit a93d90f

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

sonic_platform_base/sonic_xcvr/api/public/c_cmis.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -543,10 +543,13 @@ def get_transceiver_threshold_info(self):
543543
trans_dom_th['rxtotpowerlowalarm'] = self.vdm_dict['Rx Total Power [dBm]'][1][2]
544544
trans_dom_th['rxtotpowerhighwarning'] = self.vdm_dict['Rx Total Power [dBm]'][1][3]
545545
trans_dom_th['rxtotpowerlowwarning'] = self.vdm_dict['Rx Total Power [dBm]'][1][4]
546-
trans_dom_th['rxsigpowerhighalarm'] = self.vdm_dict['Rx Signal Power [dBm]'][1][1]
547-
trans_dom_th['rxsigpowerlowalarm'] = self.vdm_dict['Rx Signal Power [dBm]'][1][2]
548-
trans_dom_th['rxsigpowerhighwarning'] = self.vdm_dict['Rx Signal Power [dBm]'][1][3]
549-
trans_dom_th['rxsigpowerlowwarning'] = self.vdm_dict['Rx Signal Power [dBm]'][1][4]
546+
try:
547+
trans_dom_th['rxsigpowerhighalarm'] = self.vdm_dict['Rx Signal Power [dBm]'][1][1]
548+
trans_dom_th['rxsigpowerlowalarm'] = self.vdm_dict['Rx Signal Power [dBm]'][1][2]
549+
trans_dom_th['rxsigpowerhighwarning'] = self.vdm_dict['Rx Signal Power [dBm]'][1][3]
550+
trans_dom_th['rxsigpowerlowwarning'] = self.vdm_dict['Rx Signal Power [dBm]'][1][4]
551+
except KeyError:
552+
pass
550553
return trans_dom_th
551554

552555
def get_transceiver_status(self):

sonic_platform_base/sonic_xcvr/api/public/cmis.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,12 @@ def tx_disable_channel(self, channel, disable):
573573

574574
return self.xcvr_eeprom.write(consts.TX_DISABLE_FIELD, channel_state)
575575

576+
def get_power_override(self):
577+
return None
578+
579+
def set_power_override(self, power_override, power_set):
580+
return True
581+
576582
def get_transceiver_thresholds_support(self):
577583
return not self.is_flat_memory()
578584

tests/sonic_xcvr/test_cmis.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,11 @@ def test_tx_disable_channel(self, mock_response, input_param):
503503
self.api.get_tx_disable_channel.return_value = mock_response
504504
self.api.tx_disable_channel(*input_param)
505505

506+
def test_get_power_override(self):
507+
self.api.get_power_override()
508+
509+
def test_set_power_override(self):
510+
self.api.set_power_override(None, None)
506511
@pytest.mark.parametrize("mock_response, expected", [
507512
(False, True)
508513
])

0 commit comments

Comments
 (0)