From 00be1fb5bc33ba92f37648369ef1159a62817cc4 Mon Sep 17 00:00:00 2001 From: Yutong Zhang <90831468+yutongzhang-microsoft@users.noreply.github.com> Date: Mon, 28 Aug 2023 15:06:31 +0800 Subject: [PATCH] Revert PR #9256 "Remove pg lossless settings of port speed in module iface_namingmode/test_iface_namingmode.py". (#9621) What is the motivation for this PR? In PR #9256, we use function delete_running_config to delete pg lossless profile in running config, which will cause orchagent coredump. Actually, from SAI side, they don't support such usage. So in module iface_namingmode/test_iface_namingmode.py, after case test_config_interface_speed running, we use our fixture core_dump_and_config_check to do config reload to recover config, thus revert this PR. --- tests/iface_namingmode/test_iface_namingmode.py | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/iface_namingmode/test_iface_namingmode.py b/tests/iface_namingmode/test_iface_namingmode.py index 94e070d8c15..1d0c571549c 100644 --- a/tests/iface_namingmode/test_iface_namingmode.py +++ b/tests/iface_namingmode/test_iface_namingmode.py @@ -4,7 +4,7 @@ import ipaddress from tests.common.devices.base import AnsibleHostBase -from tests.common.utilities import wait, wait_until, delete_running_config +from tests.common.utilities import wait, wait_until from netaddr import IPAddress from tests.common.helpers.assertions import pytest_assert from tests.common.helpers.sonic_db import redis_get_keys @@ -820,13 +820,6 @@ def test_config_interface_speed(self, setup_config_mode, sample_intf, assert speed == configure_speed - # Remove interface pg config - pg_lossless_key = "pg_lossless_" + str(speed) + "_300m_profile" - delete_keys_json = [{"BUFFER_PROFILE": { - pg_lossless_key: {} - }}] - delete_running_config(delete_keys_json, duthost) - out = dutHostGuest.shell('SONIC_CLI_IFACE_MODE={} sudo config interface {} speed {} {}'.format( ifmode, cli_ns_option, test_intf, native_speed)) if out['rc'] != 0: