From 35316563131f55d1e2d122953bb585265f0dab14 Mon Sep 17 00:00:00 2001 From: Nana He Date: Wed, 18 Aug 2021 17:00:03 +0800 Subject: [PATCH 1/2] Add some testcase in the testcase.yml file --- ansible/roles/test/vars/testcases.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ansible/roles/test/vars/testcases.yml b/ansible/roles/test/vars/testcases.yml index 1385901213d..8d3aa9f17b8 100644 --- a/ansible/roles/test/vars/testcases.yml +++ b/ansible/roles/test/vars/testcases.yml @@ -259,7 +259,7 @@ testcases: reboot: filename: reboot.yml - topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64] + topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64, ptf-any] repeat_harness: filename: repeat_harness.yml @@ -280,7 +280,7 @@ testcases: sensors: filename: sensors_check.yml vtestbed_compatible: no - topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64] + topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64, ptf-any] service_acl: filename: service_acl.yml @@ -352,3 +352,7 @@ testcases: read_mac: filename: read_mac_metadata.yml topologies: [t0, t1, t1-lag] + + port_mirroring: + filename: test_port_mirroring.py + topologies: [t0] From f4feb981713accc24558195c8fdbd684d64d751e Mon Sep 17 00:00:00 2001 From: Nana He Date: Tue, 7 Sep 2021 16:47:06 +0800 Subject: [PATCH 2/2] Modify AbnormalFanMocker check_result return value Return True if the actual fan data is same with the mock data, else return False. --- .../mellanox/mellanox_thermal_control_test_helper.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/platform_tests/mellanox/mellanox_thermal_control_test_helper.py b/tests/platform_tests/mellanox/mellanox_thermal_control_test_helper.py index 765d744f4a2..ebde725d386 100644 --- a/tests/platform_tests/mellanox/mellanox_thermal_control_test_helper.py +++ b/tests/platform_tests/mellanox/mellanox_thermal_control_test_helper.py @@ -1008,9 +1008,10 @@ def check_result(self, actual_data): self.expect_led_color) except SysfsNotExistError as e: logging.info('LED check only support on SPC2 and SPC3: {}'.format(e)) - return - - assert 0, 'Expected data not found' + return True + + logging.error('Expected data not found') + return False def is_fan_removable(self): """