From 504c8c9e48a1a3d857bce34029f90ef75c97f38a Mon Sep 17 00:00:00 2001 From: Danny Allen Date: Tue, 29 Sep 2020 18:08:35 -0700 Subject: [PATCH 1/2] [drop counters] Disable IGMP test for testbeds without proper fanout support Signed-off-by: Danny Allen --- tests/drop_packets/drop_packets.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/drop_packets/drop_packets.py b/tests/drop_packets/drop_packets.py index 184d421268e..ad0bc5b88d5 100644 --- a/tests/drop_packets/drop_packets.py +++ b/tests/drop_packets/drop_packets.py @@ -664,6 +664,11 @@ def test_non_routable_igmp_pkts(do_test, ptfadapter, duthost, setup, tx_dut_port # records=[gr_obj]).build() # The rest packets are build like "simple_igmp_packet" function from PTF testutils.py + # FIXME: Need some sort of configuration for EOS and SONiC fanout hosts to + # not drop IGMP packets before they reach the DUT + if not fanouthost: + pytest.skip("Test case requires explicit fanout support") + from scapy.contrib.igmp import IGMP Ether = testutils.scapy.Ether IP = testutils.scapy.IP From 60001e040f644a1df8415fafb44f4d7d5e4a9156 Mon Sep 17 00:00:00 2001 From: Danny Allen Date: Tue, 29 Sep 2020 20:00:37 -0700 Subject: [PATCH 2/2] Dropped the arg --- tests/drop_packets/drop_packets.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/drop_packets/drop_packets.py b/tests/drop_packets/drop_packets.py index ad0bc5b88d5..73ff3005821 100644 --- a/tests/drop_packets/drop_packets.py +++ b/tests/drop_packets/drop_packets.py @@ -635,7 +635,7 @@ def test_unicast_ip_incorrect_eth_dst(do_test, ptfadapter, duthost, setup, tx_du @pytest.mark.parametrize("igmp_version,msg_type", [("v1", "general_query"), ("v3", "general_query"), ("v1", "membership_report"), ("v2", "membership_report"), ("v3", "membership_report"), ("v2", "leave_group")]) -def test_non_routable_igmp_pkts(do_test, ptfadapter, duthost, setup, tx_dut_ports, pkt_fields, igmp_version, msg_type, ports_info): +def test_non_routable_igmp_pkts(do_test, ptfadapter, duthost, setup, fanouthost, tx_dut_ports, pkt_fields, igmp_version, msg_type, ports_info): """ @summary: Create an IGMP non-routable packets. """