diff --git a/tests/pfcwd/conftest.py b/tests/pfcwd/conftest.py index 60857dcd7bd..48b16f7f2a9 100644 --- a/tests/pfcwd/conftest.py +++ b/tests/pfcwd/conftest.py @@ -9,6 +9,7 @@ from tests.common.fixtures.ptfhost_utils import change_mac_addresses # noqa F401 from tests.common.fixtures.ptfhost_utils import pause_garp_service # noqa F401 from tests.common.mellanox_data import is_mellanox_device as isMellanoxDevice +from tests.common.cisco_data import is_cisco_device from .files.pfcwd_helper import TrafficPorts, set_pfc_timers, select_test_ports from tests.common.utilities import str2bool @@ -75,7 +76,8 @@ def fake_storm(request, duthosts, enum_rand_one_per_hwsku_frontend_hostname): fake_storm: False/True """ duthost = duthosts[enum_rand_one_per_hwsku_frontend_hostname] - return request.config.getoption('--fake-storm') if not isMellanoxDevice(duthost) else False + return False if (isMellanoxDevice(duthost) or is_cisco_device(duthost)) \ + else request.config.getoption('--fake-storm') def update_t1_test_ports(duthost, mg_facts, test_ports, tbinfo): diff --git a/tests/pfcwd/test_pfcwd_function.py b/tests/pfcwd/test_pfcwd_function.py index 0ca620b1675..c52231ff970 100644 --- a/tests/pfcwd/test_pfcwd_function.py +++ b/tests/pfcwd/test_pfcwd_function.py @@ -723,7 +723,8 @@ def storm_detect_path(self, dut, port, action): test_ports_info = {self.pfc_wd['rx_port'][0]: self.pfc_wd} queues = [self.storm_hndle.pfc_queue_idx] - if dut.facts['asic_type'] == "mellanox": + extra_pfc_storm_timeout_needed = dut.facts['asic_type'] in ["mellanox", "cisco-8000"] + if extra_pfc_storm_timeout_needed: PFC_STORM_TIMEOUT = 30 pfcwd_stats_before_test = check_pfc_storm_state(dut, port, self.storm_hndle.pfc_queue_idx) @@ -743,7 +744,7 @@ def storm_detect_path(self, dut, port, action): if self.pfc_wd['fake_storm']: PfcCmd.set_storm_status(dut, self.queue_oid, "enabled") - if dut.facts['asic_type'] in ["mellanox", "cisco-8000"]: + if extra_pfc_storm_timeout_needed: # On Mellanox platform, more time is required for PFC storm being triggered # as PFC pause sent from Non-Mellanox leaf fanout is not continuous sometimes. pytest_assert(wait_until(PFC_STORM_TIMEOUT, 2, 0,