Skip to content

Commit e3b6fbe

Browse files
mannytaheriwangxin
authored andcommitted
Ignore two syslog messages when doing reboot/config_reload of T2 chassis with DNX chipset (#6056)
What is the motivation for this PR? When we reboot / config_reload on T2 chassis cards, we see 2 error messages in the linecards During config_reload/reboot of linecard, LAGS are deleted, but ports are up, and we get mac learning events from SAI to orchagent which is in middle of cleanup and doesn't have the right data. This causes error message like Failed to get port by bridge port ID reboot/config_reload on supoervisor will cause all the fabric links in the linecard to bounce which results in SAI sending messages orchagent regarding the fabric port state change. However, in linecards in T2 chassis, there is modelling of fabric ports in orchagent. Thus, orchagent generates error message indication to port object found for the port. How did you do it? Created ignore_t2_syslog_msgs method in dut_utils.py Called the method in cases when we do rebbot or reload - tests/common/config_reload.py - tests/common/reboot.py - tests/platform_tests/api/test_module.py How did you verify/test it? Tested the reboot/reload testcases
1 parent 30cbddc commit e3b6fbe

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

tests/platform_tests/api/test_module.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def test_get_name(self, duthosts, enum_rand_one_per_hwsku_hostname, localhost, p
108108
for i in range(self.num_modules):
109109
if self.skip_absent_module(i,platform_api_conn):
110110
continue
111-
name = module.get_name(platform_api_conn, i)
111+
name = module.get_name(platform_api_conn, i)
112112
if self.expect(name is not None, "Unable to retrieve module {} name".format(i)):
113113
self.expect(isinstance(name, STRING_TYPE), "Module {} name appears incorrect".format(i))
114114
self.assert_expectations()
@@ -458,7 +458,6 @@ def test_reboot(self, duthosts, enum_rand_one_per_hwsku_hostname, localhost, pla
458458
# Extend ignore fabric port msgs for T2 chassis with DNX chipset on Linecards
459459
ignore_t2_syslog_msgs(duthosts[enum_rand_one_per_hwsku_hostname])
460460

461-
support_reboot_other_modules = self.get_module_facts(duthosts[enum_rand_one_per_hwsku_hostname], True, "reboot_other_modules")
462461
for mod_idx in range(self.num_modules):
463462
mod_name = module.get_name(platform_api_conn, mod_idx)
464463
if self.skip_module_other_than_myself(mod_idx,platform_api_conn):

0 commit comments

Comments
 (0)