Skip to content

Commit a8170d7

Browse files
authored
Skip all admin down ports for non-Mellanox device (#6433)
* remove asic type and speed check, skip all admin down ports on broadcom's device What is the motivation for this PR? There was no BUFFER_PROFILE_TABLE for admin down ports How did you do it? Skip all admin down ports for Broadcom device How did you verify/test it? Verify the original failure case Signed-off-by: xuliping <xuliping@microsoft.com>
1 parent 6890ed5 commit a8170d7

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

tests/qos/test_buffer.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2481,15 +2481,8 @@ def _check_port_buffer_info_and_return(duthost, table, ids, port, expected_profi
24812481
else:
24822482
if is_mellanox_device(duthost):
24832483
buffer_items_to_check = buffer_items_to_check_dict["down"][key_name]
2484-
elif is_broadcom_device(duthost) and (asic_type in ['td2', 'td3'] or speed <= '10000'):
2485-
buffer_items_to_check = [(None, None, None)]
24862484
else:
2487-
if key_name == KEY_2_LOSSLESS_QUEUE:
2488-
buffer_items_to_check = [('BUFFER_PG_TABLE', '3-4', profile_wrapper.format(expected_profile))]
2489-
else:
2490-
buffer_items_to_check.extend(
2491-
[('BUFFER_PG_TABLE', '2-4', profile_wrapper.format(expected_profile)),
2492-
('BUFFER_PG_TABLE', '6', profile_wrapper.format(expected_profile))])
2485+
buffer_items_to_check = [(None, None, None)]
24932486

24942487
for table, ids, expected_profile in buffer_items_to_check:
24952488
logging.info("Checking buffer item {}:{}:{}".format(table, port, ids))

0 commit comments

Comments
 (0)