Commit 49335ba
authored
remove low speed port from test port list for breakout test scenario (#12084)
What is the motivation for this PR?
Regarding to 7050qx's QoS SAI test for topo t0:
test port select result is as below:
testPortIds={0: {0:
[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24]}};
and 1,2,3 are low speed breakout port. as below:
admin@bjw-can-7050qx-3:~$ show int st
Interface Lanes Speed MTU FEC Alias Vlan Oper Admin Type Asym PFC
Ethernet0 9 10G 9100 N/A Ethernet1 routed up down SFP/SFP+/SFP28 off
Ethernet1 10 10G 9100 N/A Ethernet2 trunk up up SFP/SFP+/SFP28 off
Ethernet2 11 10G 9100 N/A Ethernet3 trunk up up SFP/SFP+/SFP28 off
Ethernet3 12 1G 9100 N/A Ethernet4 trunk up up SFP/SFP+/SFP28 off
Ethernet4 13,14,15,16 40G 9100 N/A Ethernet6/1 trunk up up QSFP+ or later with SFF-8636 or SFF-8436 off
it cause two issue:
caused using wrong test target porfile for qos sai test. as below:
profileName = ingressLosslessProfile["profileName"] >>>>> [Xu]: just get profile of first test port, in this function.
logger.info(
"Lossless Buffer profile selected is {}".format(profileName))
if self.isBufferInApplDb(dut_asic):
profile_pattern = "^BUFFER_PROFILE_TABLE\\:pg_lossless_(.*)_profile$"
else:
profile_pattern = "^BUFFER_PROFILE\\|pg_lossless_(.*)_profile"
m = re.search(profile_pattern, profileName)
pytest_assert(m.group(1), "Cannot find port speed/cable length")
# portSpeedCableLength = m.group(1)
portSpeedCableLength = "40000_300m" >>>> [Xu]: according to above sample result of test port selection, first port' id is 1 (it's Etherent1), the corresponding PG lossless porfile is "pg_lossless_10000_300m_profile". so we can never get expected pg_lossless_40000_300m_profile profile.
cause qos sai test traffic go through low speed breakout port rather than high speed 40G port
and eventually, caused Xon case failure.
How did you do it?
remove low speed port out of test port list
How did you verify/test it?
pass UT1 parent 282a231 commit 49335ba
2 files changed
+19
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| 45 | + | |
| 46 | + | |
44 | 47 | | |
45 | 48 | | |
46 | 49 | | |
| |||
794 | 797 | | |
795 | 798 | | |
796 | 799 | | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
797 | 806 | | |
798 | 807 | | |
799 | 808 | | |
| |||
847 | 856 | | |
848 | 857 | | |
849 | 858 | | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
850 | 868 | | |
851 | 869 | | |
852 | 870 | | |
| 871 | + | |
853 | 872 | | |
854 | 873 | | |
855 | 874 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
142 | | - | |
143 | 141 | | |
144 | 142 | | |
145 | 143 | | |
| |||
0 commit comments