[everflow_testbed]: Test everflow session over spine and tor ports. (#160)

Author: oleksandrivantsiv

ansible/roles/test/files/acstests/everflow_tb_test.py

@@ -72,7 +72,7 @@ def setUp(self):
         self.session_ttl = int(self.test_params['session_ttl'])
         self.session_dscp = int(self.test_params['session_dscp'])
         self.src_port = int(float(self.test_params['src_port']))
-        self.dst_ports = [int(float(p)) for p in self.test_params['dst_ports'].split(",")]
+        self.dst_ports = [int(float(p)) for p in self.test_params['dst_ports'].split(",") if p]
         self.expected_dst_mac = self.test_params.get('expected_dst_mac', None)
 
         testutils.add_filter(self.gre_type_filter)

ansible/roles/test/tasks/everflow_testbed.yml

@@ -4,6 +4,14 @@
 
 - name: Run Everflow tests.
   include: "roles/test/tasks/everflow_testbed/run_test.yml"
+  vars:
+    dst_port_type: "tor"
+  tags: everflow_tb_test
+
+- name: Run Everflow tests.
+  include: "roles/test/tasks/everflow_testbed/run_test.yml"
+  vars:
+    dst_port_type: "spine"
   tags: everflow_tb_test
 
 - name: Clear Everflow configuration.

ansible/roles/test/tasks/everflow_testbed/apply_config/acl_table.j2

@@ -3,7 +3,7 @@
         "ACL_TABLE:acl_table_mirror": {
             "policy_desc" : "Everflow_ACL_table",
             "type" : "MIRROR",
-            "ports" : "{% for ifname, v in minigraph_neighbors.iteritems() %}{% if "T0" in v.name %}{{"%s" % alias_reverse_map[ifname]}},{% endif %}{% endfor %}"
+            "ports" : "{% for ifname, v in minigraph_neighbors.iteritems() %}{{"%s" % alias_reverse_map[ifname]}},{% endfor %}"
         },
         "OP": "SET"
     }

ansible/roles/test/tasks/everflow_testbed/get_port_info.yml

@@ -1,6 +1,18 @@
-- name: Init list with tor ports.
+- fail: msg="Destination port type is not defined"
+  when: dst_port_type not in ['tor', 'spine']
+
+- name: Init variables.
   set_fact:
       tor_ports: []
+      spine_ports: []
+      dst_port_1_is_lag_member: ""
+      dst_port_1_ptf_id: ""
+      dst_port_2: ""
+      dst_port_2_is_lag_member: ""
+      dst_port_2_ptf_id: ""
+      dst_port_3: ""
+      dst_port_3_is_lag_member: ""
+      dst_port_3_ptf_id: ""
 
 - name: Get tor ports
   set_fact:
@@ -12,38 +24,128 @@
   set_fact:
       tor_port: "{{ tor_ports|sort }}"
 
-- name: Print top ports
+- name: Print tor ports
   debug: msg="{{ tor_ports }}"
 
-- name: Define port variables.
+- name: Get spine ports
+  set_fact:
+      spine_ports: "{{ spine_ports + [item.key]  }}"
+  with_dict: "{{ minigraph_neighbors }}"
+  when: "'T2' in item.value.name"
+
+- name: Sort tor ports by name.
+  set_fact:
+      tor_port: "{{ spine_ports|sort }}"
+
+- name: Print spine ports
+  debug: msg="{{ spine_ports }}"
+
+- name: Define SRC port variables.
+  set_fact:
+      src_port: "{{ spine_ports[0] }}"
+  when: "dst_port_type == 'tor'"
+
+- name: Define SRC port variables.
   set_fact:
       src_port: "{{ tor_ports[0] }}"
+  when: "dst_port_type == 'spine'"
+
+- name: Define SRC PTF port IDs
+  set_fact:
+      src_port_ptf_id: "{{ alias_reverse_map[src_port]|replace(\"Ethernet\", \"\")|int / 4 }}"
+
+- name: Define port variables.
+  set_fact:
       dst_port_1: "{{ tor_ports[1] }}"
-      dst_port_2: "{{ tor_ports[2] }}"
-      dst_port_3: "{{ tor_ports[3] }}"
+  when: "dst_port_type == 'tor'"
 
-- name: Print port variables.
-  debug:
-      var: src_port
+- name: Define port variables.
+  set_fact:
+      dst_port_1: "{{ spine_ports[1] }}"
+  when: "dst_port_type == 'spine'"
 
-- name: Print port variables.
-  debug:
-      var: dst_port_1
+- name: Check if DST port in LAG member
+  set_fact:
+      dst_port_1_is_lag_member: "{{ item.members }}"
+  with_items: "{{ minigraph_portchannel_interfaces }}"
+  when: "dst_port_1 in item.members"
 
-- name: Print port variables.
-  debug:
-      var: dst_port_2
+- name: Define PTF port IDs for dst_port_1
+  set_fact:
+      dst_port_1_ptf_id: "{{ alias_reverse_map[dst_port_1]|replace(\"Ethernet\", \"\")|int / 4 }}"
+  when: "not dst_port_1_is_lag_member"
+
+- name: Define PTF port IDs for dst_port_1
+  set_fact:
+      dst_port_1_ptf_id: "{{ alias_reverse_map[item]|replace(\"Ethernet\", \"\")|int / 4 }},{{ dst_port_1_ptf_id }}"
+  with_items: "{{ dst_port_1_is_lag_member }}"
+  when: "dst_port_1_is_lag_member"
 
-- name: Print port variables.
+- name: Define port variables.
+  set_fact:
+      dst_port_2: "{{ item }}"
+  with_items: "{{ tor_ports }}"
+  when: "(dst_port_type == 'tor') and (not dst_port_2) and (item != dst_port_1) and (item not in dst_port_1_is_lag_member)"
+
+- name: Define port variables.
+  set_fact:
+      dst_port_2: "{{ item }}"
+  with_items: "{{ spine_ports }}"
+  when: "(dst_port_type == 'spine') and (not dst_port_2) and (item != dst_port_1) and (item not in dst_port_1_is_lag_member)"
+
+- name: Check if DST port in LAG member
+  set_fact:
+      dst_port_2_is_lag_member: "{{ item.members }}"
+  with_items: "{{ minigraph_portchannel_interfaces }}"
+  when: "dst_port_2 in item.members"
+
+- name: Print port channels
   debug:
-      var: dst_port_3
+      var: dst_port_2_is_lag_member
 
-- name: Define PTF port IDs
+- name: Define PTF port IDs for dst_port_2
   set_fact:
-      src_port_ptf_id: "{{ alias_reverse_map[src_port]|replace(\"Ethernet\", \"\")|int / 4 }}"
-      dst_port_1_ptf_id: "{{ alias_reverse_map[dst_port_1]|replace(\"Ethernet\", \"\")|int / 4 }}"
       dst_port_2_ptf_id: "{{ alias_reverse_map[dst_port_2]|replace(\"Ethernet\", \"\")|int / 4 }}"
+  when: "not dst_port_2_is_lag_member"
+
+- name: Define PTF port IDs for dst_port_2
+  set_fact:
+      dst_port_2_ptf_id: "{{ alias_reverse_map[item]|replace(\"Ethernet\", \"\")|int / 4 }},{{ dst_port_2_ptf_id }}"
+  with_items: "{{ dst_port_2_is_lag_member }}"
+  when: "dst_port_2_is_lag_member"
+
+- name: Define port variables.
+  set_fact:
+      dst_port_3: "{{ item }}"
+  with_items: "{{ tor_ports }}"
+  when: "(dst_port_type == 'tor') and (not dst_port_3) and (item != dst_port_1) and (item != dst_port_2) and (item not in dst_port_1_is_lag_member) and (item not in dst_port_2_is_lag_member)"
+
+- name: Define port variables.
+  set_fact:
+      dst_port_3: "{{ item }}"
+  with_items: "{{ spine_ports }}"
+  when: "(dst_port_type == 'spine') and (not dst_port_3) and (item != dst_port_1) and (item != dst_port_2) and (item not in dst_port_1_is_lag_member) and (item not in dst_port_2_is_lag_member)"
+
+- name: Check if DST port in LAG member
+  set_fact:
+      dst_port_3_is_lag_member: "{{ item.members }}"
+  with_items: "{{ minigraph_portchannel_interfaces }}"
+  when: "dst_port_3 in item.members"
+
+- name: Print port channels
+  debug:
+      var: dst_port_3_is_lag_member
+
+- name: Define PTF port IDs for dst_port_3
+  set_fact:
       dst_port_3_ptf_id: "{{ alias_reverse_map[dst_port_3]|replace(\"Ethernet\", \"\")|int / 4 }}"
+  when: "not dst_port_3_is_lag_member"
+
+- name: Define PTF port IDs for dst_port_3
+  set_fact:
+      dst_port_3_ptf_id: "{{ alias_reverse_map[item]|replace(\"Ethernet\", \"\")|int / 4 }},{{ dst_port_3_ptf_id }}"
+  with_items: "{{ dst_port_3_is_lag_member }}"
+  when: "dst_port_3_is_lag_member"
 
 - name: Print PTF port ID.
   debug: msg="{{ src_port }} = {{ src_port_ptf_id }}"

ansible/roles/test/tasks/everflow_testbed/run_test.yml

@@ -2,6 +2,12 @@
 # Run Everflow test and Perform log analysis.
 #-----------------------------------------
 
+- fail: msg="testbed_type is not defined."
+  when: testbed_type is not defined
+
+- fail: msg="testbed_type {{testbed_type}} is invalid."
+  when: testbed_type not in ['t1-lag', 't1']
+
 - name: Gathering minigraph facts about the device
   minigraph_facts: host={{ inventory_hostname }}
   become: no
@@ -67,6 +73,7 @@
 
     - name: Run testcase 4 - Change neighbor MAC address.
       include: roles/test/tasks/everflow_testbed/testcase_4.yml
+      when: testbed_type == "t1"
 
     - name: Run testcase 5 - Resolved ECMP route.
       include: roles/test/tasks/everflow_testbed/testcase_5.yml