From b5b907db1b0d692160bb597423890388c012771d Mon Sep 17 00:00:00 2001 From: Saikrishna Arcot Date: Wed, 4 Mar 2026 22:57:12 -0800 Subject: [PATCH] Always install bash-completion in image With sonic-net/sonic-utilities#4163, the bash-completion package was moved from Requires to Suggests. This means that it won't be installed by default. Make sure we install it always, so that completions work. Signed-off-by: Saikrishna Arcot --- build_debian.sh | 1 + files/build_templates/sonic_debian_extension.j2 | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/build_debian.sh b/build_debian.sh index 0bcad9d017d..51b61f1665e 100755 --- a/build_debian.sh +++ b/build_debian.sh @@ -324,6 +324,7 @@ sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y in isc-dhcp-client \ sudo \ vim \ + bash-completion \ tcpdump \ dbus \ openssh-server \ diff --git a/files/build_templates/sonic_debian_extension.j2 b/files/build_templates/sonic_debian_extension.j2 index d8ee42848e8..c96217fb031 100644 --- a/files/build_templates/sonic_debian_extension.j2 +++ b/files/build_templates/sonic_debian_extension.j2 @@ -245,8 +245,8 @@ install_deb_package $debs_path/sonic-utilities-data_*.deb # Install customized bash version to patch bash plugin support. install_deb_package $debs_path/bash_*.deb -# sonic-utilities-data installs bash-completion as a dependency. However, it is disabled by default -# in bash.bashrc, so we copy a version of the file with it enabled here. +# Bash completion is disabled by default in bash.bashrc, so we copy a version +# of the file with it enabled here. sudo cp -f $IMAGE_CONFIGS/bash/bash.bashrc $FILESYSTEM_ROOT/etc/ sudo cp -f $IMAGE_CONFIGS/bash/bash.bash_logout $FILESYSTEM_ROOT/etc/