diff --git a/src/sonic-yang-models/tests/yang_model_tests/tests/kdump.json b/src/sonic-yang-models/tests/yang_model_tests/tests/kdump.json index 4d42fb6c3d8..8cd74ecd917 100644 --- a/src/sonic-yang-models/tests/yang_model_tests/tests/kdump.json +++ b/src/sonic-yang-models/tests/yang_model_tests/tests/kdump.json @@ -11,6 +11,12 @@ "KDUMP_WITH_VALID_VALUES_4": { "desc": "Configuring the kdump with valid values." }, + "KDUMP_WITH_VALID_MEM_HIGH": { + "desc": "Configuring the kdump with valid values and high suffix." + }, + "KDUMP_WITH_VALID_MEM_HIGH_2": { + "desc": "Configuring the kdump with valid values and high suffix." + }, "KDUMP_WITH_INVALID_NUM_DUMPS": { "desc": "Configuring kdump config with a invalid number of allowed kdumps.", "eStrKey": "Range" @@ -19,6 +25,14 @@ "desc": "Configuring kdump config with invalid memory config.", "eStrKey": "Pattern" }, + "KDUMP_WITH_INVALID_MEM_HIGH": { + "desc": "Configuring kdump config with invalid value.", + "eStrKey": "Pattern" + }, + "KDUMP_WITH_INVALID_MEM_HIGH_2": { + "desc": "Configuring kdump config with invalid suffix.", + "eStrKey": "Pattern" + }, "KDUMP_WITH_VALID_REMOTE_VALUES": { "desc": "Configuring the kdump with valid remote ssh values." } diff --git a/src/sonic-yang-models/tests/yang_model_tests/tests_config/kdump.json b/src/sonic-yang-models/tests/yang_model_tests/tests_config/kdump.json index 7cfaff75061..ebefb4ffcd5 100644 --- a/src/sonic-yang-models/tests/yang_model_tests/tests_config/kdump.json +++ b/src/sonic-yang-models/tests/yang_model_tests/tests_config/kdump.json @@ -55,7 +55,34 @@ } } }, - + "KDUMP_WITH_VALID_MEM_HIGH": { + "sonic-kdump:sonic-kdump": { + "sonic-kdump:KDUMP": { + "config": { + "enabled": "true", + "num_dumps": "3", + "memory": "1G,high", + "remote": "true", + "ssh_string" : "ali@192.168.0.188", + "ssh_path": "/home/ali/.ssh/id_rsa" + } + } + } + }, + "KDUMP_WITH_VALID_MEM_HIGH_2": { + "sonic-kdump:sonic-kdump": { + "sonic-kdump:KDUMP": { + "config": { + "enabled": "true", + "num_dumps": "3", + "memory": "512M,high", + "remote": "true", + "ssh_string" : "ali@192.168.0.188", + "ssh_path": "/home/ali/.ssh/id_rsa" + } + } + } + }, "KDUMP_WITH_INVALID_NUM_DUMPS": { "sonic-kdump:sonic-kdump": { "sonic-kdump:KDUMP": { @@ -84,7 +111,34 @@ } } }, - + "KDUMP_WITH_INVALID_MEM_HIGH": { + "sonic-kdump:sonic-kdump": { + "sonic-kdump:KDUMP": { + "config": { + "enabled": "true", + "num_dumps": "3", + "memory": "100,high", + "remote": "true", + "ssh_string" : "ali@192.168.0.188", + "ssh_path": "/home/ali/.ssh/id_rsa" + } + } + } + }, + "KDUMP_WITH_INVALID_MEM_HIGH_2": { + "sonic-kdump:sonic-kdump": { + "sonic-kdump:KDUMP": { + "config": { + "enabled": "true", + "num_dumps": "3", + "memory": "1G,highx", + "remote": "true", + "ssh_string" : "ali@192.168.0.188", + "ssh_path": "/home/ali/.ssh/id_rsa" + } + } + } + }, "KDUMP_WITH_VALID_REMOTE_VALUES": { "sonic-kdump:sonic-kdump": { "sonic-kdump:KDUMP": { diff --git a/src/sonic-yang-models/yang-models/sonic-kdump.yang b/src/sonic-yang-models/yang-models/sonic-kdump.yang index 22ed5a73ae0..ca8b5842416 100644 --- a/src/sonic-yang-models/yang-models/sonic-kdump.yang +++ b/src/sonic-yang-models/yang-models/sonic-kdump.yang @@ -33,7 +33,7 @@ module sonic-kdump { leaf memory { type string { - pattern "(((([0-9]+[MG]?)?(-([0-9]+[MG])?):)?[0-9]+[MG],?)+)"; + pattern "((((([0-9]+[MG]?)?(-([0-9]+[MG])?):)?[0-9]+[MG],?)+)|([0-9]+[MG],high))"; } description "Memory reserved for loading the crash handler kernel. The amount