From 975e7211a909933a54d22b9e5e27cd1f84500d85 Mon Sep 17 00:00:00 2001 From: Samuel Angebault Date: Wed, 16 Aug 2023 02:18:19 -0700 Subject: [PATCH] [Arista] Remove one pcie device accross platforms These devices will not reliabily report the proper devid and vendorid when reading it is read directly from the pci config space. It can be read but shouldn't be compared against some fixed value like the one stored in pcie.yaml. Since this makes pcied unhappy, the simplest path forward is to just remove this device from monitoring. --- device/arista/x86_64-arista_7050dx4_32s/pcie.yaml | 5 ----- device/arista/x86_64-arista_7050px4_32s/pcie.yaml | 5 ----- device/arista/x86_64-arista_7050sx3_48c8/pcie.yaml | 5 ----- device/arista/x86_64-arista_7050sx3_48yc8/pcie.yaml | 5 ----- device/arista/x86_64-arista_7060dx4_32/pcie.yaml | 5 ----- device/arista/x86_64-arista_7060dx5_32/pcie.yaml | 1 + device/arista/x86_64-arista_7060dx5_64s/pcie.yaml | 1 + device/arista/x86_64-arista_7060px4_32/pcie.yaml | 5 ----- device/arista/x86_64-arista_7060px5_64s/pcie.yaml | 1 + device/arista/x86_64-arista_7170_32cd/pcie.yaml | 5 ----- device/arista/x86_64-arista_7170_64c/pcie.yaml | 5 ----- device/arista/x86_64-arista_720dt_48s/pcie.yaml | 5 ----- device/arista/x86_64-arista_7260cx3_64/pcie.yaml | 5 ----- device/arista/x86_64-arista_7280cr3_32p4/pcie.yaml | 5 ----- device/arista/x86_64-arista_7800_sup/pcie.yaml | 1 + device/arista/x86_64-arista_7800r3_48cq2_lc/pcie.yaml | 5 ----- device/arista/x86_64-arista_7800r3_48cqm2_lc/pcie.yaml | 5 ----- device/arista/x86_64-arista_7800r3a_36d2_lc/pcie.yaml | 5 ----- device/arista/x86_64-arista_common/pcie.yaml | 1 + 19 files changed, 5 insertions(+), 70 deletions(-) create mode 120000 device/arista/x86_64-arista_7060dx5_32/pcie.yaml create mode 120000 device/arista/x86_64-arista_7060dx5_64s/pcie.yaml create mode 120000 device/arista/x86_64-arista_7060px5_64s/pcie.yaml create mode 120000 device/arista/x86_64-arista_7800_sup/pcie.yaml create mode 100644 device/arista/x86_64-arista_common/pcie.yaml diff --git a/device/arista/x86_64-arista_7050dx4_32s/pcie.yaml b/device/arista/x86_64-arista_7050dx4_32s/pcie.yaml index 0085590fe34..30947acfbe0 100644 --- a/device/arista/x86_64-arista_7050dx4_32s/pcie.yaml +++ b/device/arista/x86_64-arista_7050dx4_32s/pcie.yaml @@ -152,11 +152,6 @@ id: '1466' name: 'Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) Data Fabric: Device 18h; Function 6' -- bus: '00' - dev: '18' - fn: '7' - id: '0001' - name: 'Host bridge: Arastra Inc. Device 0001' - bus: '01' dev: '00' fn: '0' diff --git a/device/arista/x86_64-arista_7050px4_32s/pcie.yaml b/device/arista/x86_64-arista_7050px4_32s/pcie.yaml index 0085590fe34..30947acfbe0 100644 --- a/device/arista/x86_64-arista_7050px4_32s/pcie.yaml +++ b/device/arista/x86_64-arista_7050px4_32s/pcie.yaml @@ -152,11 +152,6 @@ id: '1466' name: 'Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) Data Fabric: Device 18h; Function 6' -- bus: '00' - dev: '18' - fn: '7' - id: '0001' - name: 'Host bridge: Arastra Inc. Device 0001' - bus: '01' dev: '00' fn: '0' diff --git a/device/arista/x86_64-arista_7050sx3_48c8/pcie.yaml b/device/arista/x86_64-arista_7050sx3_48c8/pcie.yaml index a0e58628f4b..17e96155041 100644 --- a/device/arista/x86_64-arista_7050sx3_48c8/pcie.yaml +++ b/device/arista/x86_64-arista_7050sx3_48c8/pcie.yaml @@ -64,11 +64,6 @@ id: '1578' name: 'Encryption controller: Advanced Micro Devices, Inc. [AMD] Carrizo Platform Security Processor' -- bus: '00' - dev: 09 - fn: '0' - id: '0001' - name: 'Host bridge: Arastra Inc. Device 0001' - bus: '00' dev: 09 fn: '2' diff --git a/device/arista/x86_64-arista_7050sx3_48yc8/pcie.yaml b/device/arista/x86_64-arista_7050sx3_48yc8/pcie.yaml index 96e42dd936e..0b9ece287ab 100644 --- a/device/arista/x86_64-arista_7050sx3_48yc8/pcie.yaml +++ b/device/arista/x86_64-arista_7050sx3_48yc8/pcie.yaml @@ -64,11 +64,6 @@ id: '1578' name: 'Encryption controller: Advanced Micro Devices, Inc. [AMD] Carrizo Platform Security Processor' -- bus: '00' - dev: 09 - fn: '0' - id: '0001' - name: 'Host bridge: Arastra Inc. Device 0001' - bus: '00' dev: 09 fn: '2' diff --git a/device/arista/x86_64-arista_7060dx4_32/pcie.yaml b/device/arista/x86_64-arista_7060dx4_32/pcie.yaml index 9417788f1db..9e1c27f8818 100644 --- a/device/arista/x86_64-arista_7060dx4_32/pcie.yaml +++ b/device/arista/x86_64-arista_7060dx4_32/pcie.yaml @@ -186,11 +186,6 @@ id: 6f37 name: 'Performance counters: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D R3 QPI Link 0/1 (rev 03)' -- bus: ff - dev: 0b - fn: '3' - id: '0001' - name: 'System peripheral: Arastra Inc. Device 0001 (rev 03)' - bus: ff dev: 0c fn: '0' diff --git a/device/arista/x86_64-arista_7060dx5_32/pcie.yaml b/device/arista/x86_64-arista_7060dx5_32/pcie.yaml new file mode 120000 index 00000000000..df18a601d82 --- /dev/null +++ b/device/arista/x86_64-arista_7060dx5_32/pcie.yaml @@ -0,0 +1 @@ +../x86_64-arista_common/pcie.yaml \ No newline at end of file diff --git a/device/arista/x86_64-arista_7060dx5_64s/pcie.yaml b/device/arista/x86_64-arista_7060dx5_64s/pcie.yaml new file mode 120000 index 00000000000..df18a601d82 --- /dev/null +++ b/device/arista/x86_64-arista_7060dx5_64s/pcie.yaml @@ -0,0 +1 @@ +../x86_64-arista_common/pcie.yaml \ No newline at end of file diff --git a/device/arista/x86_64-arista_7060px4_32/pcie.yaml b/device/arista/x86_64-arista_7060px4_32/pcie.yaml index 9417788f1db..9e1c27f8818 100644 --- a/device/arista/x86_64-arista_7060px4_32/pcie.yaml +++ b/device/arista/x86_64-arista_7060px4_32/pcie.yaml @@ -186,11 +186,6 @@ id: 6f37 name: 'Performance counters: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D R3 QPI Link 0/1 (rev 03)' -- bus: ff - dev: 0b - fn: '3' - id: '0001' - name: 'System peripheral: Arastra Inc. Device 0001 (rev 03)' - bus: ff dev: 0c fn: '0' diff --git a/device/arista/x86_64-arista_7060px5_64s/pcie.yaml b/device/arista/x86_64-arista_7060px5_64s/pcie.yaml new file mode 120000 index 00000000000..df18a601d82 --- /dev/null +++ b/device/arista/x86_64-arista_7060px5_64s/pcie.yaml @@ -0,0 +1 @@ +../x86_64-arista_common/pcie.yaml \ No newline at end of file diff --git a/device/arista/x86_64-arista_7170_32cd/pcie.yaml b/device/arista/x86_64-arista_7170_32cd/pcie.yaml index eafae4eb147..0f8df9154cd 100644 --- a/device/arista/x86_64-arista_7170_32cd/pcie.yaml +++ b/device/arista/x86_64-arista_7170_32cd/pcie.yaml @@ -186,11 +186,6 @@ id: 6f37 name: 'Performance counters: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D R3 QPI Link 0/1 (rev 03)' -- bus: ff - dev: 0b - fn: '3' - id: '0001' - name: 'System peripheral: Arastra Inc. Device 0001 (rev 03)' - bus: ff dev: 0c fn: '0' diff --git a/device/arista/x86_64-arista_7170_64c/pcie.yaml b/device/arista/x86_64-arista_7170_64c/pcie.yaml index f2691476112..49faf89dc56 100644 --- a/device/arista/x86_64-arista_7170_64c/pcie.yaml +++ b/device/arista/x86_64-arista_7170_64c/pcie.yaml @@ -174,11 +174,6 @@ id: 6f37 name: 'Performance counters: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D R3 QPI Link 0/1 (rev 03)' -- bus: ff - dev: 0b - fn: '3' - id: '0001' - name: 'System peripheral: Arastra Inc. Device 0001 (rev 03)' - bus: ff dev: 0c fn: '0' diff --git a/device/arista/x86_64-arista_720dt_48s/pcie.yaml b/device/arista/x86_64-arista_720dt_48s/pcie.yaml index bda6ac688c7..b2ecad04bc2 100644 --- a/device/arista/x86_64-arista_720dt_48s/pcie.yaml +++ b/device/arista/x86_64-arista_720dt_48s/pcie.yaml @@ -90,11 +90,6 @@ id: 15ee name: 'Host bridge: Advanced Micro Devices, Inc. [AMD] Raven/Raven2 Device 24: Function 6' -- bus: '00' - dev: '18' - fn: '7' - id: '0001' - name: 'Host bridge: Arista Networks, Inc. Device 0001' - bus: '01' dev: '00' fn: '0' diff --git a/device/arista/x86_64-arista_7260cx3_64/pcie.yaml b/device/arista/x86_64-arista_7260cx3_64/pcie.yaml index a2540013703..24955eee42f 100644 --- a/device/arista/x86_64-arista_7260cx3_64/pcie.yaml +++ b/device/arista/x86_64-arista_7260cx3_64/pcie.yaml @@ -179,11 +179,6 @@ id: 6f37 name: 'Performance counters: Intel Corporation Xeon E7 v4/Xeon E5 v4/Xeon E3 v4/Xeon D R3 QPI Link 0/1 (rev 03)' -- bus: ff - dev: 0b - fn: '3' - id: '0001' - name: 'System peripheral: Arastra Inc. Device 0001 (rev 03)' - bus: ff dev: 0c fn: '0' diff --git a/device/arista/x86_64-arista_7280cr3_32p4/pcie.yaml b/device/arista/x86_64-arista_7280cr3_32p4/pcie.yaml index b327bf55779..7608e5e9c78 100644 --- a/device/arista/x86_64-arista_7280cr3_32p4/pcie.yaml +++ b/device/arista/x86_64-arista_7280cr3_32p4/pcie.yaml @@ -64,11 +64,6 @@ id: '1578' name: 'Encryption controller: Advanced Micro Devices, Inc. [AMD] Carrizo Platform Security Processor' -- bus: '00' - dev: 09 - fn: '0' - id: '0001' - name: 'Host bridge: Arista Networks, Inc. Device 0001' - bus: '00' dev: 09 fn: '2' diff --git a/device/arista/x86_64-arista_7800_sup/pcie.yaml b/device/arista/x86_64-arista_7800_sup/pcie.yaml new file mode 120000 index 00000000000..df18a601d82 --- /dev/null +++ b/device/arista/x86_64-arista_7800_sup/pcie.yaml @@ -0,0 +1 @@ +../x86_64-arista_common/pcie.yaml \ No newline at end of file diff --git a/device/arista/x86_64-arista_7800r3_48cq2_lc/pcie.yaml b/device/arista/x86_64-arista_7800r3_48cq2_lc/pcie.yaml index 8d7fb184997..1669ab31dad 100644 --- a/device/arista/x86_64-arista_7800r3_48cq2_lc/pcie.yaml +++ b/device/arista/x86_64-arista_7800r3_48cq2_lc/pcie.yaml @@ -152,11 +152,6 @@ id: '1466' name: 'Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) Data Fabric: Device 18h; Function 6' -- bus: '00' - dev: '18' - fn: '7' - id: '0001' - name: 'Host bridge: Arista Networks, Inc. Device 0001' - bus: '04' dev: '00' fn: '0' diff --git a/device/arista/x86_64-arista_7800r3_48cqm2_lc/pcie.yaml b/device/arista/x86_64-arista_7800r3_48cqm2_lc/pcie.yaml index 8d7fb184997..1669ab31dad 100644 --- a/device/arista/x86_64-arista_7800r3_48cqm2_lc/pcie.yaml +++ b/device/arista/x86_64-arista_7800r3_48cqm2_lc/pcie.yaml @@ -152,11 +152,6 @@ id: '1466' name: 'Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) Data Fabric: Device 18h; Function 6' -- bus: '00' - dev: '18' - fn: '7' - id: '0001' - name: 'Host bridge: Arista Networks, Inc. Device 0001' - bus: '04' dev: '00' fn: '0' diff --git a/device/arista/x86_64-arista_7800r3a_36d2_lc/pcie.yaml b/device/arista/x86_64-arista_7800r3a_36d2_lc/pcie.yaml index 4b4481f3154..882f87987b7 100644 --- a/device/arista/x86_64-arista_7800r3a_36d2_lc/pcie.yaml +++ b/device/arista/x86_64-arista_7800r3a_36d2_lc/pcie.yaml @@ -152,11 +152,6 @@ id: '1466' name: 'Host bridge: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 00h-0fh) Data Fabric: Device 18h; Function 6' -- bus: '00' - dev: '18' - fn: '7' - id: '0001' - name: 'Host bridge: Arista Networks, Inc. Device 0001' - bus: '04' dev: '00' fn: '0' diff --git a/device/arista/x86_64-arista_common/pcie.yaml b/device/arista/x86_64-arista_common/pcie.yaml new file mode 100644 index 00000000000..fe51488c706 --- /dev/null +++ b/device/arista/x86_64-arista_common/pcie.yaml @@ -0,0 +1 @@ +[]