From 1fa7abf2f5c573f58d6eb008cfce8abb04c90ef6 Mon Sep 17 00:00:00 2001 From: Ashwin Srinivasan <93744978+assrinivasan@users.noreply.github.com> Date: Tue, 18 Jul 2023 21:14:00 -0700 Subject: [PATCH] [master] Mellanox: 2700, 4600c - Quoted device IDs to prevent false flags in pcied (#15896) Why I did it Certain all-numeric device IDs of PCI devices in the pcie.yaml file are left unquoted, leading to false mismatch flags in the pcie daemon and subsequently leads to log flooding. This PR fixes that issue. Work item tracking Microsoft ADO (number only): 24578930 How I did it Added quotes around numeric PCI devices in the pcie.yaml files of the following platforms: x86_64-mlnx_msn2700-r0 x86_64-mlnx_msn4600c-r0 How to verify it Install latest image after the merge and verify that syslogs are not flooded with PCI device mismatch errors --- device/mellanox/x86_64-mlnx_msn2700-r0/pcie.yaml | 2 +- device/mellanox/x86_64-mlnx_msn4600c-r0/pcie.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/device/mellanox/x86_64-mlnx_msn2700-r0/pcie.yaml b/device/mellanox/x86_64-mlnx_msn2700-r0/pcie.yaml index 440afffc325..74c796f9438 100644 --- a/device/mellanox/x86_64-mlnx_msn2700-r0/pcie.yaml +++ b/device/mellanox/x86_64-mlnx_msn2700-r0/pcie.yaml @@ -35,7 +35,7 @@ - bus: '00' dev: '01' fn: '2' - id: 0159 + id: '0159' name: 'PCI bridge: Intel Corporation Xeon E3-1200 v2/3rd Gen Core processor PCI Express Root Port (rev 09)' - bus: '00' diff --git a/device/mellanox/x86_64-mlnx_msn4600c-r0/pcie.yaml b/device/mellanox/x86_64-mlnx_msn4600c-r0/pcie.yaml index 4356f48a250..0ec69ca08c8 100644 --- a/device/mellanox/x86_64-mlnx_msn4600c-r0/pcie.yaml +++ b/device/mellanox/x86_64-mlnx_msn4600c-r0/pcie.yaml @@ -154,7 +154,7 @@ - bus: '09' dev: '00' fn: '0' - id: 1533 + id: '1533' name: 'Ethernet controller: Intel Corporation I210 Gigabit Network Connection (rev 03)' - bus: 'ff'