From 81cdfbdecadf5b0b9158ce9908a57696a58e9289 Mon Sep 17 00:00:00 2001
From: shilongliu <shilongliu@microsoft.com>
Date: Mon, 21 Mar 2022 15:13:53 +0800
Subject: [PATCH] [ci] Fix remove sonic-slave-* docker image issue

---
 .azure-pipelines/azure-pipelines-UpgrateVersion.yml | 12 +-----------
 .azure-pipelines/docker-sonic-slave-template.yml    | 11 +----------
 .azure-pipelines/template-clean-sonic-slave.yml     |  8 ++++++++
 3 files changed, 10 insertions(+), 21 deletions(-)
 create mode 100644 .azure-pipelines/template-clean-sonic-slave.yml

diff --git a/.azure-pipelines/azure-pipelines-UpgrateVersion.yml b/.azure-pipelines/azure-pipelines-UpgrateVersion.yml
index 0c7f7f96629..4f1625b297a 100644
--- a/.azure-pipelines/azure-pipelines-UpgrateVersion.yml
+++ b/.azure-pipelines/azure-pipelines-UpgrateVersion.yml
@@ -45,17 +45,7 @@ stages:
       jobFilters: ${{ parameters.jobFilters }}
       buildOptions: '${{ variables.VERSION_CONTROL_OPTIONS }} SONIC_BUILD_JOBS=$(nproc) ENABLE_IMAGE_SIGNATURE=y'
       preSteps:
-      - script: |
-          containers=$(docker container ls | grep "sonic-slave" | awk '{ print $1 }')
-          if [ ! -z "$containers" ]; then
-            docker container kill $containers || true
-            sleep 5
-          fi
-          images=$(docker images 'sonic-slave-*' -a -q)
-          if [ ! -z "$images" ]; then
-            docker rmi -f $images
-          fi
-        displayName: 'Cleanup sonic slave'
+      - template: template-clean-sonic-slave.yml
 - stage: UpgradeVersions
   jobs:
   - job: UpgradeVersions
diff --git a/.azure-pipelines/docker-sonic-slave-template.yml b/.azure-pipelines/docker-sonic-slave-template.yml
index a8b00fa576b..212b449abb1 100644
--- a/.azure-pipelines/docker-sonic-slave-template.yml
+++ b/.azure-pipelines/docker-sonic-slave-template.yml
@@ -38,6 +38,7 @@ jobs:
   pool: ${{ parameters.pool }}
   steps:
   - template: cleanup.yml
+  - template: template-clean-sonic-slave.yml
   - checkout: self
     clean: true
     submodules: recursive
@@ -68,16 +69,6 @@ jobs:
         BUILD_OPTIONS = 'SONIC_VERSION_CONTROL_COMPONENTS=deb,py2,py3,web,git,docker'
       fi
 
-      containers=$(docker container ls | grep "sonic-slave" | awk '{ print $1 }')
-      if [ ! -z "$containers" ]; then
-        docker container kill $containers || true
-        sleep 5
-      fi
-      images=$(docker images 'sonic-slave-*' -a -q)
-      if [ ! -z "$images" ]; then
-        docker rmi -f $images
-      fi
-
       tmpfile=$(mktemp)
 
       echo ${{ parameters.arch }} > .arch
diff --git a/.azure-pipelines/template-clean-sonic-slave.yml b/.azure-pipelines/template-clean-sonic-slave.yml
new file mode 100644
index 00000000000..cc995e9c262
--- /dev/null
+++ b/.azure-pipelines/template-clean-sonic-slave.yml
@@ -0,0 +1,8 @@
+steps:
+- script: |
+    containers=$(docker container ls -a | grep "sonic-slave" | awk '{ print $1 }')
+    [ -n "$containers" ] && docker container rm -f containers
+    docker images | grep "^<none>" | awk '{print$3}' | xargs -i docker rmi {}
+    images=$(docker images 'sonic-slave-*' -a -q)
+    [ -n "$images" ] && docker rmi -f $images
+  displayName: 'Cleanup sonic slave'