Revert "[bgpcfgd]BGP suppress fib pending support for multi-asic (#23187)" (#24883)

This reverts commit 1b2cead.

- Not sending suppress-fib-pending configuration to FRR is intentional
to avoid traffic distruption. As per design, the suppress-fib-pending
is non-distruptively handled by avoiding sending the
suppress-fib-pending command to FRR. Therefore reverting to address
issue: #24679

Signed-off-by: vedganes <veda.ganesan@nokia.com>
Signed-off-by: Feng Pan <fenpan@microsoft.com>

Author: vganesan-nokia

src/sonic-bgpcfgd/bgpcfgd/managers_db.py

@@ -19,30 +19,10 @@ def __init__(self, common_objs, db, table):
 
     def set_handler(self, key, data):
         """ Implementation of 'SET' command for this class """
-
-        if self.__set_handler_validate(key, data) == True:
-            cmd_list = []
-            bgp_asn = data["bgp_asn"]
-            state = data["suppress-fib-pending"]
-            cmd_list.append("router bgp %s" % bgp_asn)
-            if state == "disabled":
-                cmd_list.append("no bgp suppress-fib-pending")
-            else:
-                cmd_list.append("bgp suppress-fib-pending")
-            cmd_list.append("exit")
-
-            self.cfg_mgr.push_list(cmd_list)
-
         self.directory.put(self.db_name, self.table_name, key, data)
 
         return True
 
     def del_handler(self, key):
         """ Implementation of 'DEL' command for this class """
-        self.directory.remove(self.db_name, self.table_name, key)
-
-    def __set_handler_validate(self, key, data):
-        if data:
-            if ((key == "localhost") and ("bgp_asn" in data) and ("suppress-fib-pending" in data and data["suppress-fib-pending"] in ["enabled","disabled"])):
-                 return True
-        return False
+        self.directory.remove(self.db_name, self.table_name, key)

src/sonic-bgpcfgd/tests/test_db.py

@@ -30,14 +30,6 @@ def test_set_del_handler():
     assert "test_key2" in m.directory.get_slot(m.db_name, m.table_name)
     assert m.directory.get(m.db_name, m.table_name, "test_key2") == {}
 
-    res = m.set_handler("localhost", {'bgp_asn':'65100','suppress-fib-pending':'enabled'})
-    assert res, "Returns always True"
-    assert m.directory.get(m.db_name, m.table_name, "localhost") == {'bgp_asn':'65100','suppress-fib-pending':'enabled'}
-
-    res = m.set_handler("localhost", {'bgp_asn':'65100','suppress-fib-pending':'disabled'})
-    assert res, "Returns always True"
-    assert m.directory.get(m.db_name, m.table_name, "localhost") == {'bgp_asn':'65100','suppress-fib-pending':'disabled'}
-
     # test del_handler
     m.del_handler("test_key")
     assert "test_key" not in m.directory.get_slot(m.db_name, m.table_name)