Skip to content

Commit c32cd1f

Browse files
committed
Fix mech tests
1 parent b987b9d commit c32cd1f

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

lib/CXGN/BrAPI/v2/ObservationUnits.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ sub _search {
290290
foreach my $i (@{$obs_unit->{intercrop_stocks}}) {
291291
push(@intercrop, { germplasmDbId => $i->{id}, germplasmName => $i->{name} });
292292
}
293-
$additional_info->{intercropGermplasm} = \@intercrop;
293+
$additional_info->{intercropGermplasm} = \@intercrop if scalar(@intercrop) > 0;
294294
}
295295

296296
push @data_window, {

lib/CXGN/Trial/TrialLayoutSearch.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ sub search {
152152
#For performance reasons the number of joins to stock can be reduced if a trial is given.
153153

154154
my $from_clause = " FROM stock as observationunit
155-
JOIN stock_relationship ON (observationunit.stock_id=stock_relationship.subject_id) AND stock_relationship.type_id = $plot_rel_type_id
155+
JOIN stock_relationship ON (observationunit.stock_id=stock_relationship.subject_id)
156156
JOIN cvterm as observationunit_type ON (observationunit_type.cvterm_id = observationunit.type_id)
157157
JOIN stock as germplasm ON (stock_relationship.object_id=germplasm.stock_id) AND germplasm.type_id IN ($accession_type_id, $cross_type_id, $family_name_type_id)
158158
JOIN cvterm as germplasm_type ON (germplasm_type.cvterm_id = germplasm.type_id)

t/unit_fixture/CXGN/Uploading/TrialUpload.t

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,6 @@ for my $extension ("xls", "xlsx", "csv") {
683683
}
684684
};
685685

686-
# FAILS
687686
is_deeply($parsed_data, $parsed_data_check, 'check trial excel parse data');
688687

689688
my $trial_create = CXGN::Trial::TrialCreate

0 commit comments

Comments
 (0)