chore: build typedefs for all packages before typechecking #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2023
steveluscher
added
the
automerge
mergify
bot
removed
the
automerge
Contributor
|
Automerge label removed due to a CI failure |
## Summary Sometimes package A depends on package B, and needs to read its typedefs to be able to typecheck _itself_. This implies that typedefs need to be built _before_ typechecking. This PR adds `compile:typedefs` as a dependency of `test:typecheck`.
Contributor
|
🎉 This PR is included in version 1.73.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: build typedefs for all packages before typechecking
Summary
Sometimes package A depends on package B, and needs to read its typedefs to be able to typecheck itself. This implies that typedefs need to be built before typechecking. This PR adds
compile:typedefsas a dependency oftest:typecheck.Stack created with Sapling. Best reviewed with ReviewStack.
localhostbeing an alias for 127.0.0.1 in tests #1200