fix(iOS): Distinguish horizontal and vertical scroll in gesture failure requirements #3420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichalikk
changed the title
kligarski
approved these changes
Nov 26, 2025
kkafar
reviewed
Nov 26, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
The behaviour seems good.
One remark regarding naming & some needed research.
kmichalikk
deleted the
@kmichalikk/fullscreen-gesture-scrollview-conflict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3302
Supersedes #3304
Description
This PR fixes the failure requirements for content pop gesture. The changes introduced in #3265 fixed the immediate dismissing of screen when scrolling on horizontal ScrollView, but at the same time introduced a regression for vertical scrolling. Here, we apply the failure requirement only if the ScrollView has horizontal scrolling.
Changes
Updated
RNSScreenStack'sgestureRecognizer:shouldRequireFailureOf:otherGestureRecognizerto check if ScrollView has horizontal scrolling.After changes
vertical-horizontal-scroll.mov
Testing
Use
Test1072. Make sure to check custom animations withanimationandanimationMatchesGesture.