fix(iOS): restore native behavior of auto shortening back button title #2105

zetavg · 2024-04-14T17:43:19Z

Description

Restore the iOS native behavior of automatically shorting the title of the header back button to "Back" if there is not enough space, which is documented here¹ but does not behave as expected since v3.21.

Fixes #1589.

Changes

Assign to backBarButtonItem only if actual customizations of the back button are being made.

Screenshots / GIFs

Before	After

Test code and steps to reproduce

Checklist

Included code example that can be used to test this change
Updated TS types
Updated documentation:
Ensured that CI passes

According to the document, 'On iOS this includes a label next to the button, which shows the title of the previous screen when the title fits in the available space, otherwise it says "Back".' ↩

tboba

Hey @zetavg, thanks for this PR! ❤️
Just one small comment from me 😄

tboba · 2024-04-15T05:52:52Z

ios/RNSScreenStackHeaderConfig.mm

  if (config.isBackTitleVisible) {
-    if (config.backTitleFontFamily || config.backTitleFontSize) {
+    if ((config.backTitleFontFamily &&
+         ![config.backTitleFontFamily isEqual:@"System"]) ||


Why do we need to check the font family here?

It's because due to the current implementation of @react-navigation/native-stack, backTitleFontFamily will always be assigned to the font family of fonts.regular, which will be "System" if the default theme is used.

It seems that the "System" font family is already the default on iOS, as setting the font family to "System" does not change the appearance, but in this case, will make config.backTitleFontFamily always resolve to YES.

I see. Do you know, if we could rely on the native component that represents the title of back button, instead of comparing config.backTitleFontFamily?

Thanks for the PR, this is great!

Can we have this comment in the code please? @zetavg

Thanks for the comment @tboba, but I'm sorry that due to my limited knowledge, I can't quite understand what you mean. Do you suggest we can handle this in something like the getter/setter of RNSScreenStackHeaderConfig, or the JS code in react-navigation?

@kkafar Sure, I'll add comments to explain this besides related code once we finalize the solution.

@zetavg I'm wondering if it would be possible to get title component of back title and check if it has default font set, but after further reflections I'm afraid this could lead to some flickers (setting the font and other properties -> checking the font of the native component -> setting system back 😄), so I guess we can stay with the current solution.

Thanks for explaining, I think I got your point! I do think the current solution of comparing the font against "System" isn't perfect, one way is that there may be different ways to use the same system font (maybe ".AppleSystemUIFont"? I'm not sure), and if react-navigation changes to also assign a default value to config.backTitleFontSize this will break again.

Your solution inspired me to think of a possible way to get this native behavior to work while still customizing the back button (such as changing the font or customizing the shortened "Back" text) - measure the width of the headerTitle and headerRight to see if there's enough space on layout, and replace the backButtonTitle with the shortened text or hide it. Well, flickering may be a problem.

tboba

LGTM! Let's just wait for the comment 🚀

…st "System" is needed

zetavg · 2024-04-17T14:17:23Z

Comment added! Please check if it's suitable 😃

tboba · 2024-04-18T06:34:48Z

Yeah, I think for now it's a pass 🎉

kkafar

Just one last thing

ios/RNSScreenStackHeaderConfig.mm

Co-authored-by: Kacper Kafara <[email protected]>

zetavg · 2024-04-29T14:07:19Z

Hi @kkafar, just a ping to let you know I have applied your suggestion (thanks for that!) for the change you requested. If there's anything I can do to get this PR merged, please let me know.

kkafar

I think we're all good here.

I'll retrigger CI before merging.

maciekstosio · 2024-05-07T13:36:31Z

ios/RNSScreenStackHeaderConfig.mm

    // When backBarButtonItem's title is null, back menu will use value
    // of backButtonTitle
    [backBarButtonItem setTitle:nil];
+    isBackButtonCustomized = YES;


Hi @zetavg, I know that this PR is already merged, but I wonder why do you set isBackButtonCustomized to true here. My understanding is that this else block is for the case when we hide back button, but want to preserve it in back menu. So, by default when we have navigationItem hidden we don't display anything here - nothing is customized, when we want to custom hide it from back manu then we set config.disableBackButtonMenu which is in initial condition anyway.

Quick reply - I think it's because this isBackButtonCustomized is used to determine whether we need to assign the backBarButtonItem to prevItem.backBarButtonItem later on line 556.

Since backBarButtonItem has been changed here ([backBarButtonItem setTitle:nil];), my understanding is that the changed backBarButtonItem has to be assigned to prevItem.backBarButtonItem for the changes to take effect. So it should be considered customized - or changed. Maybe it's better to rename isBackButtonCustomized to isBackBarButtonItemChanged so that it will be more clear (or use another way to track if we have changed anything on backBarButtonItem).

My guess is that if we do not set isBackButtonCustomized to true here, the back title won't be hidden as expected. I may need to verify it though.

Maybe it's better to rename isBackButtonCustomized to isBackBarButtonItemChanged ...

Oh, I see that you had already done this in #2123. 🎉

## Description ~This PR improves upon #2105. #2105 allowed to use iOS 14 default back button behavior when label is not provided. This PR allows to modify the behavior by allowing to provide UINavigationButtonBackButtonDisplayMode and enables it for custom text (without style modifications). The main problem is that we used to provide backButtonItem in most of the cases which [disables](https://developer.apple.com/documentation/uikit/uinavigationitem/3656350-backbuttondisplaymode) backButtonDisplayMode.~ This PR adds possibility to customize default behavior of back button using `backButtonDisplayMode` ([UINavigationBackButtonDisplayMode](https://developer.apple.com/documentation/uikit/uinavigationitem/backbuttondisplaymode)) for iOS. :warning: **This modifies only default back button**, when any customization is added (including headerBackTitle) in native part we create custom `RNSUIBarButtonItem` and set it as `backButtonItem`, which [disables](https://developer.apple.com/documentation/uikit/uinavigationitem/3656350-backbuttondisplaymode) `backButtonDisplayMode` behavior. I tried to make it work together with custom label (`headerBackTitle`) using `prevItem.backButtonTitle`, but due to iOS limitations it is not viable option. It influences also back button menu - changes the label of previous screen - which is not the behavior we want. To sum up, `backButtonDisplayMode` work when none of: - `headerBackTitleStyle.fontFamily` - `headerBackTitleStyle.fontSize` - `headerBackTitle` - `disableBackButtonMenu` are set. ## Screenshots / GIFs |Paper|Fabric| |-|-| |<video src="https://github.com/software-mansion/react-native-screens/assets/11800297/c6aa7697-4331-4cb4-a81d-7f77f128513d" />|<video src="https://github.com/software-mansion/react-native-screens/assets/11800297/fa0edd92-1aa2-45e5-a466-516c0ec120d2" />| <details> <summary>Example component used in tests:</summary> ```jsx import * as React from 'react'; import { Button, View, Text, StyleSheet } from 'react-native'; import { NavigationContainer, ParamListBase } from '@react-navigation/native'; import { createNativeStackNavigator } from '@react-navigation/native-stack'; import { NativeStackNavigationProp } from '@react-navigation/native-stack'; const Stack = createNativeStackNavigator(); type NavProp = { navigation: NativeStackNavigationProp<ParamListBase>; }; export default function App() { return ( <NavigationContainer> <Stack.Navigator> <Stack.Screen name="screenA" component={ScreenA} options={{ headerTitle: 'A: Home' }} /> <Stack.Screen name="screenB" component={ScreenB} options={{ headerTitle: 'B: default', backButtonDisplayMode: 'default', }} /> <Stack.Screen name="screenC" component={ScreenC} options={{ headerTitle: 'C: generic', backButtonDisplayMode: 'generic', }} /> <Stack.Screen name="screenD" component={ScreenD} options={{ headerTitle: 'D: minimal', backButtonDisplayMode: 'minimal', }} /> <Stack.Screen name="screenE" component={ScreenE} options={{ headerTitle: 'E: custom', headerBackTitle: 'Back Title', backButtonDisplayMode: 'minimal', }} /> </Stack.Navigator> </NavigationContainer> ); } const ScreenA = ({ navigation }: NavProp) => ( <View style={styles.container}> <Text>Screen A</Text> <Button onPress={() => navigation.navigate('screenB')} title="Go to screen B" /> </View> ); const ScreenB = ({ navigation }: NavProp) => ( <View style={styles.container}> <Text>Screen B</Text> <Text>backButtonDisplayMode: default</Text> <Button onPress={() => navigation.navigate('screenC')} title="Go to screen C" /> </View> ); const ScreenC = ({ navigation }: NavProp) => ( <View style={{ flex: 1, paddingTop: 50 }}> <Text>Screen C</Text> <Text>backButtonDisplayMode: generic</Text> <Button onPress={() => navigation.navigate('screenD')} title="Go to screen D" /> </View> ); const ScreenD = ({ navigation }: NavProp) => ( <View style={styles.container}> <Text>Screen D</Text> <Text>backButtonDisplayMode: minimal</Text> <Button onPress={() => navigation.navigate('screenE')} title="Go to screen E" /> </View> ); const ScreenE = (_props: NavProp) => ( <View style={styles.container}> <Text>Screen E</Text> <Text>backButtonDisplayMode omitted because of the headerBackTitle</Text> </View> ); const styles = StyleSheet.create({ container: { flex: 1, alignItems: 'center', justifyContent: 'space-around' }, }); ``` </details> ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation:  - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes Tested #1864: Paper ✅ Fabric ✅ Tested #1646: Paper ❌ Fabric ❌ - but it does not work on main too, could now be achieved using `backButtonDisplayMode: ‘minimal’` --------- Co-authored-by: Kacper Kafara <[email protected]>

- Fixes: Title truncated on NewNominationScreen by long back button title instead of "Back" - Introduced during the RN73 upgrade - software-mansion/react-native-screens#1589 - software-mansion/react-native-screens#2105 - https://github.com/software-mansion/react-native-screens/releases/tag/3.32.0

software-mansion#2105) ## Description Restore the iOS native behavior of automatically shorting the title of the header back button to "Back" if there is not enough space, which is documented [here](https://reactnavigation.org/docs/header-buttons#customizing-the-back-button)[^1] but does not behave as expected since v3.21. Fixes software-mansion#1589. ## Changes * Assign to `backBarButtonItem` only if actual customizations of the back button are being made. ## Screenshots / GIFs | Before | After | |--------|------| | ![Broken 1](https://github.com/software-mansion/react-native-screens/assets/3784687/880eaecb-54d9-48d3-95bd-5f8e6cd7b066) | ![Working 1](https://github.com/software-mansion/react-native-screens/assets/3784687/201e8006-544d-43ee-95e3-308e2f926566) | ## Test code and steps to reproduce  ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation:  - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes [^1]: According to the document, 'On iOS this includes a label next to the button, which shows the title of the previous screen when the title fits in the available space, otherwise it says "Back".' --------- Co-authored-by: Kacper Kafara <[email protected]>

…e-mansion#2123) ## Description ~This PR improves upon software-mansion#2105. software-mansion#2105 allowed to use iOS 14 default back button behavior when label is not provided. This PR allows to modify the behavior by allowing to provide UINavigationButtonBackButtonDisplayMode and enables it for custom text (without style modifications). The main problem is that we used to provide backButtonItem in most of the cases which [disables](https://developer.apple.com/documentation/uikit/uinavigationitem/3656350-backbuttondisplaymode) backButtonDisplayMode.~ This PR adds possibility to customize default behavior of back button using `backButtonDisplayMode` ([UINavigationBackButtonDisplayMode](https://developer.apple.com/documentation/uikit/uinavigationitem/backbuttondisplaymode)) for iOS. :warning: **This modifies only default back button**, when any customization is added (including headerBackTitle) in native part we create custom `RNSUIBarButtonItem` and set it as `backButtonItem`, which [disables](https://developer.apple.com/documentation/uikit/uinavigationitem/3656350-backbuttondisplaymode) `backButtonDisplayMode` behavior. I tried to make it work together with custom label (`headerBackTitle`) using `prevItem.backButtonTitle`, but due to iOS limitations it is not viable option. It influences also back button menu - changes the label of previous screen - which is not the behavior we want. To sum up, `backButtonDisplayMode` work when none of: - `headerBackTitleStyle.fontFamily` - `headerBackTitleStyle.fontSize` - `headerBackTitle` - `disableBackButtonMenu` are set. ## Screenshots / GIFs |Paper|Fabric| |-|-| |<video src="https://github.com/software-mansion/react-native-screens/assets/11800297/c6aa7697-4331-4cb4-a81d-7f77f128513d" />|<video src="https://github.com/software-mansion/react-native-screens/assets/11800297/fa0edd92-1aa2-45e5-a466-516c0ec120d2" />| <details> <summary>Example component used in tests:</summary> ```jsx import * as React from 'react'; import { Button, View, Text, StyleSheet } from 'react-native'; import { NavigationContainer, ParamListBase } from '@react-navigation/native'; import { createNativeStackNavigator } from '@react-navigation/native-stack'; import { NativeStackNavigationProp } from '@react-navigation/native-stack'; const Stack = createNativeStackNavigator(); type NavProp = { navigation: NativeStackNavigationProp<ParamListBase>; }; export default function App() { return ( <NavigationContainer> <Stack.Navigator> <Stack.Screen name="screenA" component={ScreenA} options={{ headerTitle: 'A: Home' }} /> <Stack.Screen name="screenB" component={ScreenB} options={{ headerTitle: 'B: default', backButtonDisplayMode: 'default', }} /> <Stack.Screen name="screenC" component={ScreenC} options={{ headerTitle: 'C: generic', backButtonDisplayMode: 'generic', }} /> <Stack.Screen name="screenD" component={ScreenD} options={{ headerTitle: 'D: minimal', backButtonDisplayMode: 'minimal', }} /> <Stack.Screen name="screenE" component={ScreenE} options={{ headerTitle: 'E: custom', headerBackTitle: 'Back Title', backButtonDisplayMode: 'minimal', }} /> </Stack.Navigator> </NavigationContainer> ); } const ScreenA = ({ navigation }: NavProp) => ( <View style={styles.container}> <Text>Screen A</Text> <Button onPress={() => navigation.navigate('screenB')} title="Go to screen B" /> </View> ); const ScreenB = ({ navigation }: NavProp) => ( <View style={styles.container}> <Text>Screen B</Text> <Text>backButtonDisplayMode: default</Text> <Button onPress={() => navigation.navigate('screenC')} title="Go to screen C" /> </View> ); const ScreenC = ({ navigation }: NavProp) => ( <View style={{ flex: 1, paddingTop: 50 }}> <Text>Screen C</Text> <Text>backButtonDisplayMode: generic</Text> <Button onPress={() => navigation.navigate('screenD')} title="Go to screen D" /> </View> ); const ScreenD = ({ navigation }: NavProp) => ( <View style={styles.container}> <Text>Screen D</Text> <Text>backButtonDisplayMode: minimal</Text> <Button onPress={() => navigation.navigate('screenE')} title="Go to screen E" /> </View> ); const ScreenE = (_props: NavProp) => ( <View style={styles.container}> <Text>Screen E</Text> <Text>backButtonDisplayMode omitted because of the headerBackTitle</Text> </View> ); const styles = StyleSheet.create({ container: { flex: 1, alignItems: 'center', justifyContent: 'space-around' }, }); ``` </details> ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [x] Updated documentation:  - [x] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [x] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [x] Ensured that CI passes Tested software-mansion#1864: Paper ✅ Fabric ✅ Tested software-mansion#1646: Paper ❌ Fabric ❌ - but it does not work on main too, could now be achieved using `backButtonDisplayMode: ‘minimal’` --------- Co-authored-by: Kacper Kafara <[email protected]>

## The Problem The problem is that the back button jumps, when the`backButtonDisplayMode` is set to `minimal`. |The Problem| |-| |<video src="https://github.com/user-attachments/assets/214c3af9-fdea-43a8-9976-453246a48079" /> ## Investigation The problem is noted as caused by the `backButtonDisplayMode` set to `minimal`, but that's not true. The flag that enables the `backButtonDisplayMode` looks as follows: ``` const isBackButtonDisplayModeAvailable = // On iOS 14+ Platform.OS === 'ios' && parseInt(Platform.Version, 10) >= 14 && // Doesn't have custom back title headerBackTitle == null && // Doesn't have custom styling backTitleFontFamily == null && backTitleFontSize == null && // Back button menu is not disabled headerBackButtonMenuEnabled !== false; ``` but as stated in software-mansion/react-native-screens#2105 (comment), the `backTitleFontFamily` is by default set to `System`, so it always results in `isBackButtonDisplayModeAvailable` being `false`. So, when `backButtonDisplayMode: 'minimal'` is set, those are the actual props (passed from react-navigation to react-native-screens): ``` backTitleVisible: false, backButtonDisplayMode: undefined, ``` and it results in setting the title of `UIBarButtonItem` to `nil`. This is what causes the button to jump, and it can be reproduced without react-native: |RN|Native| |-|-| |<video src="https://github.com/user-attachments/assets/cd692734-db05-43ba-ab05-50e628d36d04" />|<video src="https://github.com/user-attachments/assets/767b5daa-3418-4a9e-8071-84f5ad93e68a" />| ### Can it be fixed? **Yes**, we can set the title to a string space( `@" "`), **but** it breaks the back button menu: |Works, but breaks menu| |-| |<video src="https://github.com/user-attachments/assets/a7c00cc2-53fe-47df-b84b-4267bd4c9802" />| It seems to break the back button menu because the title and back button menu [are synced](https://developer.apple.com/forums/thread/653913?answerId=624077022#624077022), the [backButtonTitle](https://developer.apple.com/documentation/uikit/uinavigationitem/backbuttontitle?language=objc) should override it, but it does not work on our case (I guess that because of this part _"set it in the current view controller before pushing a new view controller onto the navigation stack"_). **On a side note** - you could think: "why not just pass an empty string from RN?". react-native-screens make sure that this prop is not empty (with trim), and if it is, the title from the previous screen is used. I assume it was done this way as a workaround for the back button menu issue mentioned before. ### What about `backButtonDisplayMode` then? Fixing the condition I mentioned in the first paragraph, could be the other solution. In this case, we end up with: ``` backTitleVisible: undefined (which is true, by default in native) backButtonDisplayMode: 'minimal', ``` |Works, but animation is broken| |-| |<video src="https://github.com/user-attachments/assets/ba58bca9-c766-44bb-a661-0a411f40d0d4" />| Which works, but there is no fade-out animation. |empty string|backButtonDisplayMode (no animation)| |-|-| |<video src="https://github.com/user-attachments/assets/f10554da-07ec-47ac-9a99-6a799dadd086" />|<video src="https://github.com/user-attachments/assets/c13f3b2f-c348-4ad0-af23-57f4c9a08b52" />| I don't think that this problem can be a workaround - this is a known native issue: https://stackoverflow.com/questions/77764576/setting-backbuttondisplaymode-to-minimal-breaks-large-title-animation, and given workaround is just using empty string, which brings us back to problems with `backButtonMenu`. ## What are the next steps? **[ReactNavigation]Changes from this PR** - this should solve the problem. **[RNScreens][iOS] get rid of `backTitileVisible` in `react-native-screens`** - on iOS currently this is really confusing, the only scenario where it can be used is the one described here - buggy one. I think we should get rid of this implementation and just clearly highlight that eny header modification will override this property. I wonder, what about iOS < 14 (?). **[RNScreens][Android] use `backButtonDisplayMode` instead of `backTitleVisible`** - just ignore the `generic` option. What I don't like, is that we're using iOS specific prop for Android, but react-navigation removed the `backTitleVisible` already, so maybe it's ok. --------- Co-authored-by: Satyajit Sahoo <[email protected]>

- This issue was introduced by upgrading React Navigation from 6 to 7, when I added custom fonts to the React Navigation Theme - 55743c2 - React Navigation (and really its underlying use of React Native Screens) doesn't try to convert the previous screen title into "Back" on iOS if a custom font is set, so adding a custom font in Theme broke things - https://reactnavigation.org/docs/native-stack-navigator/#headerbackbuttondisplaymode > "The space-aware behavior is disabled when: > ... > - Custom font family or size is set (e.g. with headerBackTitleStyle)" - So the simplest fix was to update the iOS header bar fonts to not use the custom Theme fonts - https://github.com/react-navigation/react-navigation/blob/df49c8a3a154fc1308a2cad71c6e2d08a2c089b7/packages/native-stack/src/views/useHeaderConfigProps.tsx#L58-L69 - I also considered manually setting the `headerBackTitle` option to literally be "Back" for long page titles, but unfortunately this showed the word Back instead of the previous page title in the iOS back menu, which is shown when long pressing the back button. Plus it was more likely that regressions would sneak in, since I'd need to remember to manually do this for every long page title. - I faced the same issue previously in 482e580 - react-navigation/react-navigation#12048 - software-mansion/react-native-screens#1589 - software-mansion/react-native-screens#2105 - https://reactnavigation.org/docs/themes/

fix(iOS): restore native behavior of auto shortening back button title

ee3ad3b

tboba reviewed Apr 15, 2024

View reviewed changes

tboba approved these changes Apr 16, 2024

View reviewed changes

chore: add comment to explain why comparing backTitleFontFamily again…

07c7e1e

…st "System" is needed

kkafar requested changes Apr 18, 2024

View reviewed changes

ios/RNSScreenStackHeaderConfig.mm Outdated Show resolved Hide resolved

Apply suggestions from code review

4272ec4

Co-authored-by: Kacper Kafara <[email protected]>

kkafar approved these changes Apr 29, 2024

View reviewed changes

kkafar merged commit cee947e into software-mansion:main Apr 29, 2024

maciekstosio reviewed May 7, 2024

View reviewed changes

maciekstosio mentioned this pull request May 9, 2024

feat(iOS): Add support for UINavigationBackButtonDisplayMode #2123

Merged

8 tasks

toomeem mentioned this pull request Jul 10, 2024

[Snyk] Upgrade react-native-screens from 3.31.1 to 3.32.0 TaqiT/HabitHero#11

Merged

asraful-cse mentioned this pull request Jul 21, 2024

[Snyk] Upgrade react-native-screens from 3.11.1 to 3.32.0 asraful-cse/planet_app_react_native#371

Open

This was referenced Jul 22, 2024

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.32.0 shonore/Fickle#1529

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.32.0 shonore/Fickle#1534

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.32.0 shonore/Fickle#1539

Open

This was referenced Jul 24, 2024

[Snyk] Upgrade react-native-screens from 3.18.2 to 3.32.0 namiml/react-native-nami-sdk#331

Open

[Snyk] Upgrade react-native-screens from 3.25.0 to 3.32.0 namiml/react-native-nami-sdk#332

Open

This was referenced Jul 25, 2024

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.32.0 shonore/Fickle#1544

Open

[Snyk] Upgrade react-native-screens from 3.0.0 to 3.32.0 shonore/Fickle#1549

Open

Cabreira97 mentioned this pull request Aug 23, 2024

[Snyk] Upgrade react-native-screens from 3.31.1 to 3.33.0 Cabreira97/Connect-Tech#5

Closed

kkafar mentioned this pull request Aug 27, 2024

Header back button does not shorten to 'Back' on iOS if there's not enough space #1589

Closed

undrthegraveyard mentioned this pull request Sep 4, 2024

[Snyk] Upgrade react-native-screens from 3.31.1 to 3.34.0 undrthegraveyard/gigslick#5

Closed

asraful-cse mentioned this pull request Sep 6, 2024

[Snyk] Upgrade react-native-screens from 3.11.1 to 3.34.0 asraful-cse/planet_app_react_native#412

Open

Ayush-Bulbule mentioned this pull request Oct 2, 2024

[Snyk] Upgrade react-native-screens from 3.22.1 to 3.34.0 Ayush-Bulbule/FoodleApp#5

Merged

tobistudio mentioned this pull request Oct 3, 2024

[Snyk] Upgrade react-native-screens from 3.27.0 to 3.34.0 tobistudio/React_Native_Audio#75

Open

maciekstosio mentioned this pull request Mar 20, 2025

fix: jumping back button react-navigation/react-navigation#12500

Merged

renovate bot mentioned this pull request Jun 6, 2025

Update react-navigation monorepo to v7 (major) jellyfin/jellyfin-ios#617

Open

1 task

Uh oh!

fix(iOS): restore native behavior of auto shortening back button title #2105

fix(iOS): restore native behavior of auto shortening back button title #2105

Uh oh!

Conversation

zetavg commented Apr 14, 2024

Description

Changes

Screenshots / GIFs

Test code and steps to reproduce

Checklist

Footnotes

Uh oh!

tboba left a comment

Choose a reason for hiding this comment

Uh oh!

tboba Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

zetavg Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

tboba Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

kkafar Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zetavg Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tboba Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zetavg Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

tboba left a comment

Choose a reason for hiding this comment

Uh oh!

zetavg commented Apr 17, 2024

Uh oh!

tboba commented Apr 18, 2024

Uh oh!

kkafar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zetavg commented Apr 29, 2024

Uh oh!

kkafar left a comment

Choose a reason for hiding this comment

Uh oh!

maciekstosio May 7, 2024

Choose a reason for hiding this comment

Uh oh!

zetavg May 12, 2024

Choose a reason for hiding this comment

Uh oh!

zetavg May 12, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kkafar Apr 15, 2024 •

edited

Loading

zetavg Apr 15, 2024 •

edited

Loading

tboba Apr 16, 2024 •

edited

Loading

kkafar left a comment •

edited

Loading