Skip to content

fix(Android): change context while running runOnUiQueueThread on 0.73 with Bridgeless #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(Android): change context while running runOnUiQueueThread on 0.73 with Bridgeless #2022

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc39df
Fix broken `runOnUiQueueThread` on 0.73 with Bridgeless
cortinico Jan 30, 2024
bdcc415
Merge remote-tracking branch 'origin/main' into patch-1
tboba Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/swmansion/rnscreens/ScreenContainer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ open class ScreenContainer(context: Context?) : ViewGroup(context) {
// The exception to this rule is `updateImmediately` which is triggered by actions
// not connected to React view hierarchy changes, but rather internal events
needsUpdate = true
(context as? ReactContext)?.runOnUiQueueThread {
(context.applicationContext as? ReactContext)?.runOnUiQueueThread {
// We schedule the update here because LayoutAnimations of `react-native-reanimated`
// sometimes attach/detach screens after the layout block of `ScreensShadowNode` has
// already run, and we want to update the container then too. In the other cases,
Expand Down