Commit 7602bcf
fix(examples): allow project node_modules to be used (#2200)
## Description
The custom resolver implemented in our `metro.config.js` right now most
likely does not conver all cases.
When working on my PR with modals for Android I've added `jotai` package
and received errors from bundler that this package is not found,
because:
1. it was not present in any nearby `node_modules` - the file that
requries it resides now in `apps/test-examples`, thus application
`node_modules` are not checked by default,
2. only our custom resolver looks into apps `node_modules` & fails to
resolve this package.
I haven't investigated why it does not work for `jotai` in particular,
because more general solution is to just let the default module
resolution algorithm look into
application `node_modules` as it should always do.
## Changes
Added application `node_modules` to the list of additional node modules
in metro config of each example application.
## Test code and steps to reproduce
Install `jotai` w/o this change, require it in any example and try to
run the application.
Then apply changes from this PR and see it works well.
## Checklist
- [ ] Ensured that CI passes1 parent a42ebcb commit 7602bcf
File tree
5 files changed
+15
-5
lines changed- Example
- FabricExample
- FabricTestExample
- TVOSExample
- TestsExample
5 files changed
+15
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
45 | | - | |
| 47 | + | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
44 | | - | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
44 | | - | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
45 | | - | |
| 47 | + | |
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
44 | | - | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
0 commit comments