Skip to content

Make RootViewGestureHandler handler cancel awaiting gestures #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

Make RootViewGestureHandler handler cancel awaiting gestures #2900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...id/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerInteractionManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ class RNGestureHandlerInteractionManager : GestureHandlerInteractionController {
return otherHandler.disallowInterruption
}

if (otherHandler is RNGestureHandlerRootHelper.RootViewGestureHandler) {
return true
}

return false
}
override fun shouldRecognizeSimultaneously(
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class RNGestureHandlerRootHelper(private val context: ReactContext, wrappedView:
}
}

private inner class RootViewGestureHandler : GestureHandler<RootViewGestureHandler>() {
internal inner class RootViewGestureHandler : GestureHandler<RootViewGestureHandler>() {
override fun onHandle(event: MotionEvent, sourceEvent: MotionEvent) {
val currentState = state
// we shouldn't stop intercepting events when there is an active handler already, which could happen when
Expand Down