Skip to content

Conversation

@HzjNeverStop
Copy link
Contributor

@HzjNeverStop HzjNeverStop commented Oct 24, 2022

  1. 支持通过 @SingletonSofaPostProcessor 注解指定 PostProcessor 以单例形式共享;
  2. 优化一些 PostProcessor 实现,减少 byType 注入,避免触发 FactoryBean 提前初始化

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1029 (8eceb15) into master (5e153c8) will decrease coverage by 0.00%.
The diff coverage is 34.37%.

@@             Coverage Diff              @@
##             master    #1029      +/-   ##
============================================
- Coverage     11.37%   11.37%   -0.01%     
  Complexity       39       39              
============================================
  Files           312      312              
  Lines          9145     9182      +37     
  Branches       1259     1261       +2     
============================================
+ Hits           1040     1044       +4     
- Misses         7954     7986      +32     
- Partials        151      152       +1     
Impacted Files Coverage Δ
...y/sofa/isle/loader/DynamicSpringContextLoader.java 0.00% <0.00%> (ø)
...a/runtime/proxy/ProxyBeanFactoryPostProcessor.java 0.00% <ø> (ø)
...ay/sofa/runtime/spring/JvmFilterPostProcessor.java 83.33% <ø> (ø)
...time/spring/SofaShareBeanFactoryPostProcessor.java 0.00% <0.00%> (ø)
...me/spring/share/SofaPostProcessorShareManager.java 0.00% <0.00%> (ø)
...onfigure/runtime/SofaRuntimeAutoConfiguration.java 91.17% <50.00%> (ø)
...spring/RuntimeContextBeanFactoryPostProcessor.java 76.00% <100.00%> (-19.00%) ⬇️
...untime/spring/ServiceBeanFactoryPostProcessor.java 28.33% <100.00%> (-0.65%) ⬇️
...ofa/runtime/spring/bean/SofaBeanNameGenerator.java 33.33% <0.00%> (-2.39%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HzjNeverStop HzjNeverStop changed the title optimize_inner_bpps Support singleton PostProcessor Oct 25, 2022
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 186ba07 into sofastack:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants