Fix: Custom server instance not attached#4127
Merged
darrachequesne merged 2 commits intosocketio:masterfrom Oct 16, 2021
Merged
Fix: Custom server instance not attached#4127darrachequesne merged 2 commits intosocketio:masterfrom
darrachequesne merged 2 commits intosocketio:masterfrom
Conversation
1 task
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
The check excluded an HTTPS server from being properly attached. Related: socketio#4124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
custom server instances not running attach function in constructor. this breaks feathers/socketio package which relies on socket.io.
New behavior
custom server instance now runs attach function in constructor
Other information (e.g. related issues)
fixes #4124