fix(sharded): properly unsubscribe when closing

darrachequesne · darrachequesne · commit 2da8d9e57afb · 2023-05-14T23:16:10.000+02:00
Providing an array of channels to the SUNSUBSCRIBE command assumes all the channels are allocated to the same slot, which is not always the case, so we need to issue one command per channel. Related: #500
diff --git a/lib/sharded-adapter.ts b/lib/sharded-adapter.ts
@@ -108,7 +108,9 @@ class ShardedRedisAdapter extends ClusterAdapter {
       });
     }
 
-    return SUNSUBSCRIBE(this.subClient, channels);
+    return Promise.all(
+      channels.map((channel) => SUNSUBSCRIBE(this.subClient, channel))
+    ).then();
   }
 
   override publishMessage(message) {

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,9 @@ class ShardedRedisAdapter extends ClusterAdapter {`
`108`	`108`	`});`
`109`	`109`	`}`
`110`	`110`
`111`		`- return SUNSUBSCRIBE(this.subClient, channels);`
	`111`	`+ return Promise.all(`
	`112`	`+ channels.map((channel) => SUNSUBSCRIBE(this.subClient, channel))`
	`113`	`+ ).then();`
`112`	`114`	`}`
`113`	`115`
`114`	`116`	`override publishMessage(message) {`