Merge pull request #115 from so-fancy/arrayshift

paulirish · paulirish · commit e6784e63e44f · 2016-03-08T13:57:58.000-08:00
Fix #114 (array shift error)
diff --git a/libs/header_clean/header_clean.pl b/libs/header_clean/header_clean.pl
@@ -106,10 +106,10 @@
 }
 
 sub strip_empty_first_line {
-	my $foo = shift(); # Array passed in by reference
+	my $array = shift(); # Array passed in by reference
 
 	# If the first line is just whitespace remove it
-	if (defined($foo->[0]) && $foo->[0] =~ /^\s*$/) {
-		shift($foo);
+	if (defined($array->[0]) && $array->[0] =~ /^\s*$/) {
+		shift(@$array); # Throw away the first line
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -106,10 +106,10 @@`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`sub strip_empty_first_line {`
`109`		`- my $foo = shift(); # Array passed in by reference`
	`109`	`+ my $array = shift(); # Array passed in by reference`
`110`	`110`
`111`	`111`	`# If the first line is just whitespace remove it`
`112`		`- if (defined($foo->[0]) && $foo->[0] =~ /^\s*$/) {`
`113`		`- shift($foo);`
	`112`	`+ if (defined($array->[0]) && $array->[0] =~ /^\s*$/) {`
	`113`	`+ shift(@$array); # Throw away the first line`
`114`	`114`	`}`
`115`	`115`	`}`