Skip to content

Commit 9d381c3

Browse files
authored
fix: correct react-is for mjs export; remove isValidComponent check (#991)
1 parent 2210bcf commit 9d381c3

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

packages/component/src/createLoadable.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/* eslint-disable no-use-before-define, react/no-multi-comp, no-underscore-dangle */
22
import React from 'react'
3-
import * as ReactIs from 'react-is'
43
import hoistNonReactStatics from 'hoist-non-react-statics'
54
import { invariant } from './util'
65
import Context from './Context'
@@ -77,11 +76,12 @@ function createLoadable({
7776
? options.resolveComponent(module, props)
7877
: defaultResolveComponent(module)
7978

80-
if (options.resolveComponent && !ReactIs.isValidElementType(Component)) {
81-
throw new Error(
82-
`resolveComponent returned something that is not a React component!`,
83-
)
84-
}
79+
// FIXME: suppressed due to https://github.com/gregberge/loadable-components/issues/990
80+
// if (options.resolveComponent && !ReactIs.isValidElementType(Component)) {
81+
// throw new Error(
82+
// `resolveComponent returned something that is not a React component!`,
83+
// )
84+
// }
8585
hoistNonReactStatics(Loadable, Component, {
8686
preload: true,
8787
})

packages/component/src/loadable.test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ describe('#loadable', () => {
6969
})
7070

7171
afterEach(() => {
72-
// eslint-disable-next-line no-console
73-
console.error.mockRestore()
72+
jest.restoreAllMocks();
7473
})
7574

7675
it('renders nothing without a fallback', () => {

0 commit comments

Comments
 (0)