Skip to content

Commit d1016d6

Browse files
Lancernphilnik777
authored and
smeenai
committed
[CIR][Lowering] Add the concept of simple lowering and use it for unary fp2fp operations (llvm#806)
This PR is the continuation and refinement of PR llvm#434 which is originally authored by @philnik777 . Does not update it in-place since I don't have commit access to Nikolas' repo. This PR basically just rebases llvm#434 onto the latest `main`. I also updated some naming used in the original PR to keep naming styles consistent. Co-authored-by: Nikolas Klauser <[email protected]>
1 parent 54a854b commit d1016d6

File tree

8 files changed

+207
-117
lines changed

8 files changed

+207
-117
lines changed

‎clang/include/clang/CIR/Dialect/IR/CIROps.td‎

Lines changed: 66 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,48 @@ include "mlir/IR/CommonAttrConstraints.td"
3838
// CIR Ops
3939
//===----------------------------------------------------------------------===//
4040

41+
// LLVMLoweringInfo is used by cir-tablegen to generate LLVM lowering logic
42+
// automatically for CIR operations. The `llvmOp` field gives the name of the
43+
// LLVM IR dialect operation that the CIR operation will be lowered to. The
44+
// input arguments of the CIR operation will be passed in the same order to the
45+
// lowered LLVM IR operation.
46+
//
47+
// Example:
48+
//
49+
// For the following CIR operation definition:
50+
//
51+
// def FooOp : CIR_Op<"foo"> {
52+
// // ...
53+
// let arguments = (ins CIR_AnyType:$arg1, CIR_AnyType:$arg2);
54+
// let llvmOp = "BarOp";
55+
// }
56+
//
57+
// cir-tablegen will generate LLVM lowering code for the FooOp similar to the
58+
// following:
59+
//
60+
// class CIRFooOpLowering
61+
// : public mlir::OpConversionPattern<mlir::cir::FooOp> {
62+
// public:
63+
// using OpConversionPattern<mlir::cir::FooOp>::OpConversionPattern;
64+
//
65+
// mlir::LogicalResult matchAndRewrite(
66+
// mlir::cir::FooOp op,
67+
// OpAdaptor adaptor,
68+
// mlir::ConversionPatternRewriter &rewriter) const override {
69+
// rewriter.replaceOpWithNewOp<mlir::LLVM::BarOp>(
70+
// op, adaptor.getOperands()[0], adaptor.getOperands()[1]);
71+
// return mlir::success();
72+
// }
73+
// }
74+
//
75+
// If you want fully customized LLVM IR lowering logic, simply exclude the
76+
// `llvmOp` field from your CIR operation definition.
77+
class LLVMLoweringInfo {
78+
string llvmOp = "";
79+
}
80+
4181
class CIR_Op<string mnemonic, list<Trait> traits = []> :
42-
Op<CIR_Dialect, mnemonic, traits>;
82+
Op<CIR_Dialect, mnemonic, traits>, LLVMLoweringInfo;
4383

4484
//===----------------------------------------------------------------------===//
4585
// CIR Op Traits
@@ -2708,6 +2748,8 @@ def VecInsertOp : CIR_Op<"vec.insert", [Pure,
27082748
}];
27092749

27102750
let hasVerifier = 0;
2751+
2752+
let llvmOp = "InsertElementOp";
27112753
}
27122754

27132755
//===----------------------------------------------------------------------===//
@@ -2732,6 +2774,8 @@ def VecExtractOp : CIR_Op<"vec.extract", [Pure,
27322774
}];
27332775

27342776
let hasVerifier = 0;
2777+
2778+
let llvmOp = "ExtractElementOp";
27352779
}
27362780

27372781
//===----------------------------------------------------------------------===//
@@ -3762,30 +3806,32 @@ def LLroundOp : UnaryFPToIntBuiltinOp<"llround">;
37623806
def LrintOp : UnaryFPToIntBuiltinOp<"lrint">;
37633807
def LLrintOp : UnaryFPToIntBuiltinOp<"llrint">;
37643808

3765-
class UnaryFPToFPBuiltinOp<string mnemonic>
3809+
class UnaryFPToFPBuiltinOp<string mnemonic, string llvmOpName>
37663810
: CIR_Op<mnemonic, [Pure, SameOperandsAndResultType]> {
37673811
let arguments = (ins CIR_AnyFloat:$src);
37683812
let results = (outs CIR_AnyFloat:$result);
37693813
let summary = "libc builtin equivalent ignoring "
37703814
"floating point exceptions and errno";
37713815
let assemblyFormat = "$src `:` type($src) attr-dict";
3772-
}
37733816

3774-
def CeilOp : UnaryFPToFPBuiltinOp<"ceil">;
3775-
def CosOp : UnaryFPToFPBuiltinOp<"cos">;
3776-
def ExpOp : UnaryFPToFPBuiltinOp<"exp">;
3777-
def Exp2Op : UnaryFPToFPBuiltinOp<"exp2">;
3778-
def FloorOp : UnaryFPToFPBuiltinOp<"floor">;
3779-
def FAbsOp : UnaryFPToFPBuiltinOp<"fabs">;
3780-
def LogOp : UnaryFPToFPBuiltinOp<"log">;
3781-
def Log10Op : UnaryFPToFPBuiltinOp<"log10">;
3782-
def Log2Op : UnaryFPToFPBuiltinOp<"log2">;
3783-
def NearbyintOp : UnaryFPToFPBuiltinOp<"nearbyint">;
3784-
def RintOp : UnaryFPToFPBuiltinOp<"rint">;
3785-
def RoundOp : UnaryFPToFPBuiltinOp<"round">;
3786-
def SinOp : UnaryFPToFPBuiltinOp<"sin">;
3787-
def SqrtOp : UnaryFPToFPBuiltinOp<"sqrt">;
3788-
def TruncOp : UnaryFPToFPBuiltinOp<"trunc">;
3817+
let llvmOp = llvmOpName;
3818+
}
3819+
3820+
def CeilOp : UnaryFPToFPBuiltinOp<"ceil", "FCeilOp">;
3821+
def CosOp : UnaryFPToFPBuiltinOp<"cos", "CosOp">;
3822+
def ExpOp : UnaryFPToFPBuiltinOp<"exp", "ExpOp">;
3823+
def Exp2Op : UnaryFPToFPBuiltinOp<"exp2", "Exp2Op">;
3824+
def FloorOp : UnaryFPToFPBuiltinOp<"floor", "FFloorOp">;
3825+
def FAbsOp : UnaryFPToFPBuiltinOp<"fabs", "FAbsOp">;
3826+
def LogOp : UnaryFPToFPBuiltinOp<"log", "LogOp">;
3827+
def Log10Op : UnaryFPToFPBuiltinOp<"log10", "Log10Op">;
3828+
def Log2Op : UnaryFPToFPBuiltinOp<"log2", "Log2Op">;
3829+
def NearbyintOp : UnaryFPToFPBuiltinOp<"nearbyint", "NearbyintOp">;
3830+
def RintOp : UnaryFPToFPBuiltinOp<"rint", "RintOp">;
3831+
def RoundOp : UnaryFPToFPBuiltinOp<"round", "RoundOp">;
3832+
def SinOp : UnaryFPToFPBuiltinOp<"sin", "SinOp">;
3833+
def SqrtOp : UnaryFPToFPBuiltinOp<"sqrt", "SqrtOp">;
3834+
def TruncOp : UnaryFPToFPBuiltinOp<"trunc", "FTruncOp">;
37893835

37903836
class BinaryFPToFPBuiltinOp<string mnemonic>
37913837
: CIR_Op<mnemonic, [Pure, SameOperandsAndResultType]> {
@@ -3987,6 +4033,8 @@ def StackRestoreOp : CIR_Op<"stack_restore"> {
39874033

39884034
let arguments = (ins CIR_PointerType:$ptr);
39894035
let assemblyFormat = "$ptr attr-dict `:` qualified(type($ptr))";
4036+
4037+
let llvmOp = "StackRestoreOp";
39904038
}
39914039

39924040
def AsmATT : I32EnumAttrCase<"x86_att", 0>;

‎clang/include/clang/CIR/Dialect/IR/CMakeLists.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,7 @@ mlir_tablegen(CIROpsStructs.cpp.inc -gen-attrdef-defs)
2727
mlir_tablegen(CIROpsAttributes.h.inc -gen-attrdef-decls)
2828
mlir_tablegen(CIROpsAttributes.cpp.inc -gen-attrdef-defs)
2929
add_public_tablegen_target(MLIRCIREnumsGen)
30+
31+
clang_tablegen(CIRBuiltinsLowering.inc -gen-cir-builtins-lowering
32+
SOURCE CIROps.td
33+
TARGET CIRBuiltinsLowering)

‎clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp‎

Lines changed: 13 additions & 99 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,34 +1330,6 @@ class CIRVectorCreateLowering
13301330
}
13311331
};
13321332

1333-
class CIRVectorInsertLowering
1334-
: public mlir::OpConversionPattern<mlir::cir::VecInsertOp> {
1335-
public:
1336-
using OpConversionPattern<mlir::cir::VecInsertOp>::OpConversionPattern;
1337-
1338-
mlir::LogicalResult
1339-
matchAndRewrite(mlir::cir::VecInsertOp op, OpAdaptor adaptor,
1340-
mlir::ConversionPatternRewriter &rewriter) const override {
1341-
rewriter.replaceOpWithNewOp<mlir::LLVM::InsertElementOp>(
1342-
op, adaptor.getVec(), adaptor.getValue(), adaptor.getIndex());
1343-
return mlir::success();
1344-
}
1345-
};
1346-
1347-
class CIRVectorExtractLowering
1348-
: public mlir::OpConversionPattern<mlir::cir::VecExtractOp> {
1349-
public:
1350-
using OpConversionPattern<mlir::cir::VecExtractOp>::OpConversionPattern;
1351-
1352-
mlir::LogicalResult
1353-
matchAndRewrite(mlir::cir::VecExtractOp op, OpAdaptor adaptor,
1354-
mlir::ConversionPatternRewriter &rewriter) const override {
1355-
rewriter.replaceOpWithNewOp<mlir::LLVM::ExtractElementOp>(
1356-
op, adaptor.getVec(), adaptor.getIndex());
1357-
return mlir::success();
1358-
}
1359-
};
1360-
13611333
class CIRVectorCmpOpLowering
13621334
: public mlir::OpConversionPattern<mlir::cir::VecCmpOp> {
13631335
public:
@@ -3156,19 +3128,6 @@ class CIRPtrDiffOpLowering
31563128
}
31573129
};
31583130

3159-
class CIRFAbsOpLowering : public mlir::OpConversionPattern<mlir::cir::FAbsOp> {
3160-
public:
3161-
using OpConversionPattern<mlir::cir::FAbsOp>::OpConversionPattern;
3162-
3163-
mlir::LogicalResult
3164-
matchAndRewrite(mlir::cir::FAbsOp op, OpAdaptor adaptor,
3165-
mlir::ConversionPatternRewriter &rewriter) const override {
3166-
rewriter.replaceOpWithNewOp<mlir::LLVM::FAbsOp>(
3167-
op, adaptor.getOperands().front());
3168-
return mlir::success();
3169-
}
3170-
};
3171-
31723131
class CIRExpectOpLowering
31733132
: public mlir::OpConversionPattern<mlir::cir::ExpectOp> {
31743133
public:
@@ -3248,19 +3207,8 @@ class CIRStackSaveLowering
32483207
}
32493208
};
32503209

3251-
class CIRStackRestoreLowering
3252-
: public mlir::OpConversionPattern<mlir::cir::StackRestoreOp> {
3253-
public:
3254-
using OpConversionPattern<mlir::cir::StackRestoreOp>::OpConversionPattern;
3255-
3256-
mlir::LogicalResult
3257-
matchAndRewrite(mlir::cir::StackRestoreOp op, OpAdaptor adaptor,
3258-
mlir::ConversionPatternRewriter &rewriter) const override {
3259-
rewriter.replaceOpWithNewOp<mlir::LLVM::StackRestoreOp>(op,
3260-
adaptor.getPtr());
3261-
return mlir::success();
3262-
}
3263-
};
3210+
#define GET_BUILTIN_LOWERING_CLASSES
3211+
#include "clang/CIR/Dialect/IR/CIRBuiltinsLowering.inc"
32643212

32653213
class CIRUnreachableLowering
32663214
: public mlir::OpConversionPattern<mlir::cir::UnreachableOp> {
@@ -3603,38 +3551,6 @@ class CIRUnaryFPBuiltinOpLowering : public mlir::OpConversionPattern<CIROp> {
36033551
}
36043552
};
36053553

3606-
using CIRCeilOpLowering =
3607-
CIRUnaryFPBuiltinOpLowering<mlir::cir::CeilOp, mlir::LLVM::FCeilOp>;
3608-
using CIRCosOpLowering =
3609-
CIRUnaryFPBuiltinOpLowering<mlir::cir::CosOp, mlir::LLVM::CosOp>;
3610-
using CIRExpOpLowering =
3611-
CIRUnaryFPBuiltinOpLowering<mlir::cir::ExpOp, mlir::LLVM::ExpOp>;
3612-
using CIRExp2OpLowering =
3613-
CIRUnaryFPBuiltinOpLowering<mlir::cir::Exp2Op, mlir::LLVM::Exp2Op>;
3614-
using CIRFloorOpLowering =
3615-
CIRUnaryFPBuiltinOpLowering<mlir::cir::FloorOp, mlir::LLVM::FFloorOp>;
3616-
using CIRFabsOpLowering =
3617-
CIRUnaryFPBuiltinOpLowering<mlir::cir::FAbsOp, mlir::LLVM::FAbsOp>;
3618-
using CIRLogOpLowering =
3619-
CIRUnaryFPBuiltinOpLowering<mlir::cir::LogOp, mlir::LLVM::LogOp>;
3620-
using CIRLog10OpLowering =
3621-
CIRUnaryFPBuiltinOpLowering<mlir::cir::Log10Op, mlir::LLVM::Log10Op>;
3622-
using CIRLog2OpLowering =
3623-
CIRUnaryFPBuiltinOpLowering<mlir::cir::Log2Op, mlir::LLVM::Log2Op>;
3624-
using CIRNearbyintOpLowering =
3625-
CIRUnaryFPBuiltinOpLowering<mlir::cir::NearbyintOp,
3626-
mlir::LLVM::NearbyintOp>;
3627-
using CIRRintOpLowering =
3628-
CIRUnaryFPBuiltinOpLowering<mlir::cir::RintOp, mlir::LLVM::RintOp>;
3629-
using CIRRoundOpLowering =
3630-
CIRUnaryFPBuiltinOpLowering<mlir::cir::RoundOp, mlir::LLVM::RoundOp>;
3631-
using CIRSinOpLowering =
3632-
CIRUnaryFPBuiltinOpLowering<mlir::cir::SinOp, mlir::LLVM::SinOp>;
3633-
using CIRSqrtOpLowering =
3634-
CIRUnaryFPBuiltinOpLowering<mlir::cir::SqrtOp, mlir::LLVM::SqrtOp>;
3635-
using CIRTruncOpLowering =
3636-
CIRUnaryFPBuiltinOpLowering<mlir::cir::TruncOp, mlir::LLVM::FTruncOp>;
3637-
36383554
using CIRLroundOpLowering =
36393555
CIRUnaryFPBuiltinOpLowering<mlir::cir::LroundOp, mlir::LLVM::LroundOp>;
36403556
using CIRLLroundOpLowering =
@@ -3909,23 +3825,21 @@ void populateCIRToLLVMConversionPatterns(mlir::RewritePatternSet &patterns,
39093825
CIRSwitchFlatOpLowering, CIRPtrDiffOpLowering, CIRCopyOpLowering,
39103826
CIRMemCpyOpLowering, CIRFAbsOpLowering, CIRExpectOpLowering,
39113827
CIRVTableAddrPointOpLowering, CIRVectorCreateLowering,
3912-
CIRVectorInsertLowering, CIRVectorExtractLowering, CIRVectorCmpOpLowering,
3913-
CIRVectorSplatLowering, CIRVectorTernaryLowering,
3828+
CIRVectorCmpOpLowering, CIRVectorSplatLowering, CIRVectorTernaryLowering,
39143829
CIRVectorShuffleIntsLowering, CIRVectorShuffleVecLowering,
3915-
CIRStackSaveLowering, CIRStackRestoreLowering, CIRUnreachableLowering,
3916-
CIRTrapLowering, CIRInlineAsmOpLowering, CIRSetBitfieldLowering,
3917-
CIRGetBitfieldLowering, CIRPrefetchLowering, CIRObjSizeOpLowering,
3918-
CIRIsConstantOpLowering, CIRCmpThreeWayOpLowering, CIRLroundOpLowering,
3919-
CIRLLroundOpLowering, CIRLrintOpLowering, CIRLLrintOpLowering,
3920-
CIRCeilOpLowering, CIRCosOpLowering, CIRExpOpLowering, CIRExp2OpLowering,
3921-
CIRFloorOpLowering, CIRFAbsOpLowering, CIRLogOpLowering,
3922-
CIRLog10OpLowering, CIRLog2OpLowering, CIRNearbyintOpLowering,
3923-
CIRRintOpLowering, CIRRoundOpLowering, CIRSinOpLowering,
3924-
CIRSqrtOpLowering, CIRTruncOpLowering, CIRCopysignOpLowering,
3830+
CIRStackSaveLowering, CIRUnreachableLowering, CIRTrapLowering,
3831+
CIRInlineAsmOpLowering, CIRSetBitfieldLowering, CIRGetBitfieldLowering,
3832+
CIRPrefetchLowering, CIRObjSizeOpLowering, CIRIsConstantOpLowering,
3833+
CIRCmpThreeWayOpLowering, CIRLroundOpLowering, CIRLLroundOpLowering,
3834+
CIRLrintOpLowering, CIRLLrintOpLowering, CIRCopysignOpLowering,
39253835
CIRFModOpLowering, CIRFMaxOpLowering, CIRFMinOpLowering, CIRPowOpLowering,
39263836
CIRClearCacheOpLowering, CIRUndefOpLowering, CIREhTypeIdOpLowering,
39273837
CIRCatchParamOpLowering, CIRResumeOpLowering, CIRAllocExceptionOpLowering,
3928-
CIRThrowOpLowering>(converter, patterns.getContext());
3838+
CIRThrowOpLowering
3839+
#define GET_BUILTIN_LOWERING_LIST
3840+
#include "clang/CIR/Dialect/IR/CIRBuiltinsLowering.inc"
3841+
#undef GET_BUILTIN_LOWERING_LIST
3842+
>(converter, patterns.getContext());
39293843
}
39303844

39313845
namespace {

‎clang/test/CIR/Lowering/builtin-floating-point.cir‎

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
// RUN: cir-opt %s -cir-to-llvm -o %t.ll
2+
// RUN: FileCheck --input-file=%t.ll %s
3+
4+
module {
5+
cir.func @test(%arg0 : !cir.float) {
6+
%1 = cir.cos %arg0 : !cir.float
7+
// CHECK: llvm.intr.cos(%arg0) : (f32) -> f32
8+
9+
%2 = cir.ceil %arg0 : !cir.float
10+
// CHECK: llvm.intr.ceil(%arg0) : (f32) -> f32
11+
12+
%3 = cir.exp %arg0 : !cir.float
13+
// CHECK: llvm.intr.exp(%arg0) : (f32) -> f32
14+
15+
%4 = cir.exp2 %arg0 : !cir.float
16+
// CHECK: llvm.intr.exp2(%arg0) : (f32) -> f32
17+
18+
%5 = cir.fabs %arg0 : !cir.float
19+
// CHECK: llvm.intr.fabs(%arg0) : (f32) -> f32
20+
21+
%6 = cir.floor %arg0 : !cir.float
22+
// CHECK: llvm.intr.floor(%arg0) : (f32) -> f32
23+
24+
%7 = cir.log %arg0 : !cir.float
25+
// CHECK: llvm.intr.log(%arg0) : (f32) -> f32
26+
27+
%8 = cir.log10 %arg0 : !cir.float
28+
// CHECK: llvm.intr.log10(%arg0) : (f32) -> f32
29+
30+
%9 = cir.log2 %arg0 : !cir.float
31+
// CHECK: llvm.intr.log2(%arg0) : (f32) -> f32
32+
33+
%10 = cir.nearbyint %arg0 : !cir.float
34+
// CHECK: llvm.intr.nearbyint(%arg0) : (f32) -> f32
35+
36+
%11 = cir.rint %arg0 : !cir.float
37+
// CHECK: llvm.intr.rint(%arg0) : (f32) -> f32
38+
39+
%12 = cir.round %arg0 : !cir.float
40+
// CHECK: llvm.intr.round(%arg0) : (f32) -> f32
41+
42+
%13 = cir.sin %arg0 : !cir.float
43+
// CHECK: llvm.intr.sin(%arg0) : (f32) -> f32
44+
45+
%14 = cir.sqrt %arg0 : !cir.float
46+
// CHECK: llvm.intr.sqrt(%arg0) : (f32) -> f32
47+
48+
cir.return
49+
}
50+
}

0 commit comments

Comments
 (0)