Skip to content

Commit 7e79592

Browse files
committed
Remove testscript conditionals for Go versions < 1.24
Since we're now supporting Go 1.24+, there's no need to maintain the exclusion of some test cases using `[go1.24]`, so those were removed.
1 parent c186eb7 commit 7e79592

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

integration/testdata/crypto/jwk-create-rsa.txtar

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ check_jwk rsa-2048-ps512.pub rsa-2048-ps512.priv RSA 2048 PS512
5353
stderr 'flag ''--size'' requires at least 2048 unless ''--insecure'' flag is provided'
5454

5555

56-
# RSA 1024, PS256 with insecure flag; skipped on Go < 1.24, because small keys were supported on those
57-
[go1.24] ! exec step crypto jwk create --password-file password.txt --kty RSA --size 1024 --alg PS256 rsa-1024-ps256.pub rsa-1024-ps256.priv --insecure
58-
[go1.24] stderr 'the size of the RSA key should be at least 2048 bits'
56+
# RSA 1024, PS256 with insecure flag
57+
! exec step crypto jwk create --password-file password.txt --kty RSA --size 1024 --alg PS256 rsa-1024-ps256.pub rsa-1024-ps256.priv --insecure
58+
stderr 'the size of the RSA key should be at least 2048 bits'
5959

6060

6161
# RSA 0, PS256

integration/testdata/crypto/keypair.txtar

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ stderr 'flag ''--size'' requires at least 2048 unless ''--insecure'' flag is pro
6767
stderr 'flag ''--size'' must be greater than or equal to 0'
6868

6969

70-
# RSA size 16 with insecure flag; skipped on Go < 1.24, because small keys were supported on those
71-
[go1.24] ! exec step crypto keypair --password-file password.txt --kty RSA --size 16 --insecure rsa-error.pub rsa-error.priv
72-
[go1.24] stderr 'error generating RSA key: crypto/rsa: 16-bit keys are insecure'
70+
# RSA size 16 with insecure flag
71+
! exec step crypto keypair --password-file password.txt --kty RSA --size 16 --insecure rsa-error.pub rsa-error.priv
72+
stderr 'error generating RSA key: crypto/rsa: 16-bit keys are insecure'
7373

7474

7575
# RSA size 1024 without insecure flag

0 commit comments

Comments
 (0)