-
Notifications
You must be signed in to change notification settings - Fork 74
[ENH] JohnsonQPDRegressor for quantile to probability conversion #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] JohnsonQPDRegressor for quantile to probability conversion #657
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice - I've started the tests.
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice contribution, but did you run check_estimator (from utils) on the new estimator? That allows you to debug failures quickly.
|
Thanks for the feedback @fkiraly! I ran the automated tests via pytest which showed them being skipped with NOTSET. I haven't run |
|
@RakshithaKowlikar, sounds like something is wrong with your local setup or our test setup with |
…ng for JohnsonQPDRegressor
Yes! The problem was on my end. I have rectified the code and now it doesn't show any fails. Also I think we should add venv to |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: why are you making changes to the qpd distributions? If these need changes, then maybe open a separate PR and explain what you are doing?
|
Changes to
Changes in
@fkiraly should i still open a pr for the changes in |
|
Also the errors seem to be linked with |
This PR adds JohnsonQPDRegressor, a wrapper that transforms any sklearn-style quantile regressor into a probabilistic regressor using the Johnson Quantile-Parameterized Distribution (QPD).
Fixes #377
quantileparameterModified Files
skpro/regression/compose/_johnson_quantile.py- New implementationskpro/regression/compose/__init__.py- Added importdocs/source/api_reference/regression.rst- Added to API documentation