Skip to content

Conversation

@noisecapella
Copy link
Contributor

@noisecapella noisecapella commented Aug 14, 2017

Purpose (TL;DR) - mandatory

Fix #1526 by adding exceptionCreator to the list of fields checked in isPresent

Background (Problem in detail) - optional

The PR #1511 broke this behavior because it added exceptionCreator as a field which stored a function which would create the exception.

Solution - optional

The check was added in isPresent so that the behavior is detected as being set.

How to verify - mandatory

If you run the new test on master it should fail, and it should pass on this branch.

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@fatso83 fatso83 merged commit 28bcedc into sinonjs:master Aug 14, 2017
@fatso83
Copy link
Contributor

fatso83 commented Aug 14, 2017

Thanks! Manually verified too.

@noisecapella noisecapella deleted the gs/regression_onfirstcall branch August 14, 2017 14:33
@mroderick
Copy link
Member

Thank you :)

@mroderick mroderick added the semver:patch changes will cause a new patch version label Aug 22, 2017
@mroderick
Copy link
Member

This was released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch changes will cause a new patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants