Add PackageJson and LiteralUnion types

[BendingBender]

Will do the eslint types in a later PR.

[sindresorhus]

Why allow undefined?

[BendingBender]

In strict mode, the type of the index signature has to match with the other keys defined in the type. This is the reason I've used the

type Foo = {
  key?: string;
} & {
  [key: string]: string;
}

below.

[sindresorhus]

Should we use @alias? http://usejsdoc.org/tags-alias.html

[sindresorhus]

Suggested change

	[k: string]: unknown;
	[key: string]: unknown;

[sindresorhus]

Why is this in a separate intersection type?

[BendingBender]

See https://github.com/sindresorhus/type-fest/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc#discussion_r265348876

[sindresorhus]

Can you move npm.ts to a source directory? (Don't forget to add source to files in package.json).

[sindresorhus]

I think the filenames for source/test should be npm => package-json

[sindresorhus]

Can you add the types to the readme?

[BendingBender]

Which ones? Every single one or only the main PackageJson?

[sindresorhus]

Only PackageJson and LiteralUnion

[sindresorhus]

Thanks :)

[sindresorhus]

@BendingBender Was wondering if you would like to join this project as a maintainer? No commitment, just want to show your name in the readme since you have contributed a lot of code here and you might have opinions about future type additions.

[BendingBender]

@sindresorhus It would be a pleasure for me!