Discard stdin by default

[stroncium]

Add consumeStdin option, fixes #97

Though I have no idea how to write tests for it.

Plus, if some other library decides to something like what we do here, but won't be as careful as we are, things might get ugly. But that's mostly limitation of node's way of handling things.

[sindresorhus]

I don't feel that consumeStdin perfectly describes what it does. It reads as if we actually use the stdin for something. How about something like swallowStdin, or something even clearer? Ideas?

[stroncium]

Well, I don't see much difference between swallow and consume to be honest. >_<

But generally I have no better idea than consume, as it is the word usually used to describe that behavior towards terminal inputs.

[GuillaumeRochat]

I don't feel that consumeStdin perfectly describes what it does. It reads as if we actually use the stdin for something. How about something like swallowStdin, or something even clearer? Ideas?

Would something along the line of discardStdin be clearer? Searching the web for discard stdin got me some relevant results

[sindresorhus]

I think ignoreStdin would be a better option name from a user perspective. (discardStdin could work too)

[sindresorhus]

Though I have no idea how to write tests for it.

You could add a manual test, like https://github.com/sindresorhus/ora/blob/master/example.js, so we can manually verify that it ignores Enter etc, and correctly resets stdin back to normal when being stopped.

[stroncium]

@sindresorhus added to example.js

[stroncium]

Changed the name to discardStdin (ignoreStdin still feels weird, as it is actually ignored if the option is false).

[stroncium]

@sindresorhus Shouldn't we set this behavior as default, by the way? There is almost no cases when people wouldn't wan't it to be this way, I imagine.

[sindresorhus]

Shouldn't we set this behavior as default, by the way?

👍