Fix infinite loop when retrying with request.options in afterResponse hook

Fixes #2414

Author: sindresorhus

source/core/options.ts

@@ -1034,7 +1034,10 @@ export default class Options {
 		}
 
 		if (options instanceof Options) {
-			for (const init of options._init) {
+			// Create a copy of the _init array to avoid infinite loop
+			// when merging an Options instance with itself
+			const initArray = [...options._init];
+			for (const init of initArray) {
 				this.merge(init);
 			}
 

test/infinite-loop-issue.ts

@@ -0,0 +1,35 @@
+import test from 'ava';
+import withServer from './helpers/with-server.js';
+
+// Test for issue #2414: Endless recurrent loop upon retry in options.js
+// https://github.com/sindresorhus/got/issues/2414
+test('does not cause infinite loop when retrying with request.options', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.statusCode = 401;
+		response.end();
+	});
+
+	let isCalled = false;
+
+	await got({
+		hooks: {
+			afterResponse: [
+				(response, retry) => {
+					if (!isCalled) {
+						isCalled = true;
+						// This used to cause an infinite loop in versions 12-14
+						return retry(response.request.options);
+					}
+
+					return response;
+				},
+			],
+		},
+		throwHttpErrors: false,
+		retry: {
+			limit: 0,
+		},
+	});
+
+	t.true(isCalled);
+});