Backport #1543: Initialize globalResponse in case of ignored HTTPError (#2017)

Author: nextlevelbeard

source/as-promise/index.ts

@@ -124,13 +124,13 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
 					return;
 				}
 
+				globalResponse = response;
+				
 				if (!isResponseOk(response)) {
 					request._beforeError(new HTTPError(response));
 					return;
 				}
 
-				globalResponse = response;
-
 				resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
 			});
 

test/promise.ts

@@ -85,3 +85,13 @@ test('promise.json() can be called before a file stream body is open', withServe
 
 	await Promise.all(checks);
 });
+
+test('promise.json() does not fail when server returns an error and throwHttpErrors is disabled', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.statusCode = 400;
+		response.end('{}');
+	});
+
+	const promise = got('', {throwHttpErrors: false});
+	await t.notThrowsAsync(promise.json());
+});