[VAULT-39235]: pipeline(changed-files): don't group underscore prefixed changelogs as enterprise only files (hashicorp#8906) (hashicorp#8934)

Don't categorize changelog files that begin with an underscore as
enterprise only, otherwise they'll be removed when backporting changes
to CE.

Since we want to include links to commit SHAs in the changelog we have
to create the changelog in the context of CE and thus need to backport
all of those changes.

We also fix a few Go tests that hand not been updated to handle the
updated default inactive CE groups.

Signed-off-by: Ryan Cragun <[email protected]>
Co-authored-by: Ryan Cragun <[email protected]>

Author: hc-github-team-secure-vault-core

tools/pipeline/internal/pkg/changed/checkers.go

@@ -182,10 +182,6 @@ func FileGroupCheckerEnterprise(ctx context.Context, file *File) FileGroups {
 			strings.Contains(name, "_ent") && strings.HasSuffix(name, ".pb.go"):
 			return FileGroups{FileGroupEnterprise}
 		}
-	case ".txt":
-		if hasBaseDir(name, "changelog") && strings.HasPrefix(filepath.Base(name), "_") {
-			return FileGroups{FileGroupEnterprise}
-		}
 	case
 		".proto",
 		".hcl",

tools/pipeline/internal/pkg/changed/checkers_test.go

@@ -27,7 +27,7 @@ func TestFileGroupDefaultCheckers(t *testing.T) {
 		"builtin/logical/transit/something_ent.go":  {FileGroupGoApp, FileGroupEnterprise},
 		"buf.yml":                                           {FileGroupProto},
 		"changelog/1726.txt":                                {FileGroupChangelog},
-		"changelog/_1726.txt":                               {FileGroupChangelog, FileGroupEnterprise},
+		"changelog/_1726.txt":                               {FileGroupChangelog},
 		"command/server/config.go":                          {FileGroupGoApp},
 		"command/operator_raft_autopilot_state.go":          {FileGroupGoApp, FileGroupAutopilot},
 		"command/agent_ent_test.go":                         {FileGroupGoApp, FileGroupEnterprise},

tools/pipeline/internal/pkg/github/create_backport_test.go

@@ -447,7 +447,7 @@ func TestCreateBackportReq_shouldSkipRef(t *testing.T) {
 				},
 			},
 
-			skip: false,
+			skip: true,
 		},
 		"inactive ce with with docs changes": {
 			baseRefVersion: "1.17.x",
@@ -475,7 +475,7 @@ func TestCreateBackportReq_shouldSkipRef(t *testing.T) {
 				},
 			},
 
-			skip: false,
+			skip: true,
 		},
 		"inactive ce with with changelog changes": {
 			baseRefVersion: "1.17.x",
@@ -499,7 +499,7 @@ func TestCreateBackportReq_shouldSkipRef(t *testing.T) {
 					},
 				},
 				Groups: changed.FileGroups{
-					"app", "gotoolchain", "pipeline",
+					"app", "changelog", "gotoolchain",
 				},
 			},