Merge branch 'master' into dev-session-restore-cleanup

Author: ramonfelder

.github/workflows/build.yml

@@ -0,0 +1,17 @@
+name: Build PulseView artifacts
+
+on:
+  push:                # When the repo itself has a new commit on the master branch
+    branches:
+      - master
+    tags:              # When a new tag was created
+  workflow_dispatch:   # When the workflow was started manually from github
+  pull_request:
+    types:
+      - labeled        # When a pull request received a new label (e.g. "provide_binaries")
+      - synchronize    # When a pull request's branch was updated with a new commit
+
+jobs:
+  call-build-workflow:
+    name: Sigrok artifact builder
+    uses: sigrokproject/sigrok-build/.github/workflows/build.yml@master

CMakeLists.txt

@@ -19,7 +19,7 @@
 ## along with this program.  If not, see <http://www.gnu.org/licenses/>.
 ##
 
-cmake_minimum_required(VERSION 2.8.12)
+cmake_minimum_required(VERSION 2.8.12...3.31.5)
 
 project(pulseview C CXX)
 

manual/CMakeLists.txt

@@ -17,7 +17,7 @@
 ## along with this program.  If not, see <http://www.gnu.org/licenses/>.
 ##
 
-cmake_minimum_required(VERSION 2.8.12)
+cmake_minimum_required(VERSION 2.8.12...3.31.5)
 
 project(PV_MANUAL)
 

pv/data/decode/decoder.cpp

@@ -86,10 +86,6 @@ Decoder::Decoder(const srd_decoder *const dec, uint8_t stack_level) :
 	}
 
 	// Query the annotation rows and reference them by the classes that use them
-	uint32_t row_count = 0;
-	for (const GSList *rl = srd_decoder_->annotation_rows; rl; rl = rl->next)
-		row_count++;
-
 	i = 0;
 	for (const GSList *rl = srd_decoder_->annotation_rows; rl; rl = rl->next) {
 		const srd_decoder_annotation_row *const srd_row = (srd_decoder_annotation_row *)rl->data;

pv/session.cpp

@@ -628,7 +628,7 @@ void Session::set_device(shared_ptr<devices::Device> device)
 
 	signals_changed();
 
-	device_ = move(device);
+	device_ = std::move(device);
 
 	try {
 		device_->open();

pv/views/trace/analogsignal.cpp

@@ -48,11 +48,13 @@
 
 #include <libsigrokcxx/libsigrokcxx.hpp>
 
+using std::abs;
 using std::deque;
 using std::div;
 using std::div_t;
 // Note that "using std::isnan;" is _not_ put here since that would break
 // compilation on some platforms. Use "std::isnan()" instead in checks below.
+using std::fabs;
 using std::max;
 using std::make_pair;
 using std::min;
@@ -766,7 +768,7 @@ void AnalogSignal::process_next_sample_value(float x, float value)
 			// Interpolate values to create values for the intermediate pixels
 			const float start_value = prev_value_at_pixel_;
 			const float end_value = value;
-			const int steps = fabs(pixel_pos - current_pixel_pos_);
+			const int steps = abs(pixel_pos - current_pixel_pos_);
 			const double gradient = (end_value - start_value) / steps;
 			for (int i = 0; i < steps; i++) {
 				if (current_pixel_pos_ + i < 0)