Merge pull request #1 from siemhesda/patch-3-1

Patch 3 1

Author: siemhesda

.github/workflows/benchmark.yml

@@ -6,6 +6,7 @@ on:
       - '*'
     paths:
       - lib/**
+      - workspaces/**/lib/**
   issue_comment:
     types:
       - created
@@ -36,7 +37,7 @@ jobs:
             } = context
           
             if (eventName === 'pull_request' && !process.env.GITHUB_TOKEN) {
-              console.log('No GITHUB_TOKEN - from fork pull request, exiting')
+              core.info('No GITHUB_TOKEN - from fork pull request, exiting')
               return
             }
           
@@ -47,7 +48,7 @@ jobs:
                 username: payload.comment.user.login,
               })
               if (res.data.permission !== 'admin') {
-                console.log(`Commenter is not an admin, exiting`)
+                core.info(`Commenter is not an admin, exiting`)
                 return
               }
           
@@ -65,14 +66,21 @@ jobs:
               repo,
               pull_number: number,
             }).then(r => r.data)
+
+            core.info(`Pull request: ${pullRequest.number}`)
+            core.info(`Base ref: ${pullRequest.base.ref}`)
           
             const matchesRelease = pullRequest.base.ref.match(/^release\/v(\d+)$/)
             const targetSpec = matchesRelease ? matchesRelease[1] : 'latest'
+            core.info(`Target spec: ${targetSpec}`)
+
+            const eventType = `"${eventName} ${owner}/${repo}#${pullRequest.number}"`
+            core.info(`Event type: ${eventType}`)
           
             await github.rest.repos.createDispatchEvent({
-              owner,
-              repo,
-              event_type: `"${eventName} ${owner}/${repo}#${number}"`,
+              owner: 'npm',
+              repo: 'benchmarks',
+              event_type: eventType,
               client_payload: {
                 owner,
                 repo,

lib/commands/bugs.js

@@ -21,8 +21,9 @@ class Bugs extends PackageUrlCmd {
 
     // try to get it from the repo, if possible
     const info = this.hostedFromMani(mani)
-    if (info) {
-      return info.bugs()
+    const infoUrl = info?.bugs()
+    if (infoUrl) {
+      return infoUrl
     }
 
     // just send them to the website, hopefully that has some info!

lib/commands/doctor.js

@@ -99,7 +99,7 @@ const subcommands = [
 ]
 const BaseCommand = require('../base-command.js')
 class Doctor extends BaseCommand {
-  static description = 'Check your npm environment'
+  static description = 'Check the health of your npm environment'
   static name = 'doctor'
   static params = ['registry']
   static ignoreImplicitWorkspace = false

test/lib/commands/bugs.js

@@ -6,6 +6,10 @@ const pacote = {
     return spec === 'nobugs' ? {
       name: 'nobugs',
       version: '1.2.3',
+    } : spec === 'nullbugs' ? {
+      name: 'nullbugs',
+      version: '1.2.3',
+      bugs: null,
     } : spec === 'bugsurl' ? {
       name: 'bugsurl',
       version: '1.2.3',
@@ -66,6 +70,7 @@ t.test('open bugs urls & emails', async t => {
   const expected = {
     '.': 'https://example.com',
     nobugs: 'https://www.npmjs.com/package/nobugs',
+    nullbugs: 'https://www.npmjs.com/package/nullbugs',
     'bugsobj-nourl': 'https://www.npmjs.com/package/bugsobj-nourl',
     bugsurl: 'https://bugzilla.localhost/bugsurl',
     bugsobj: 'https://bugzilla.localhost/bugsobj',