fix: destroy connection when stream errors

[fenichelar]

When a stream errors (due to break, throw, etc.) the connection can remain paused indefinitely.

To reproduce, create table test with 500 rows and run the below. The script will never exit.

import { createPool } from 'mysql2';

const pool = createPool({
  database: 'test',
  host: '127.0.0.1',
  port: 3306,
  user: 'user',
});

const results = pool.query('select * from test;').stream();
for await (const result of results) {
  break;
}

pool.end();

See #3596

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.20%. Comparing base (9c51eb9) to head (cbb211c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
+ Coverage   89.09%   89.20%   +0.10%     
==========================================
  Files          86       86              
  Lines       13546    13549       +3     
  Branches     1573     1576       +3     
==========================================
+ Hits        12069    12086      +17     
+ Misses       1477     1463      -14     

Flag	Coverage Δ
compression-0	89.20% <100.00%> (+0.10%)	⬆️
compression-1	89.20% <100.00%> (+0.10%)	⬆️
static-parser-0	86.76% <100.00%> (+0.10%)	⬆️
static-parser-1	87.53% <100.00%> (+0.10%)	⬆️
tls-0	88.61% <100.00%> (+0.10%)	⬆️
tls-1	88.86% <66.66%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wellwelwel]

Thanks, @fenichelar! I'll test locally by forcing an error and check the feasibility of including your example as a test 🙋🏻‍♂️

[fenichelar]

@wellwelwel test added.

[wellwelwel]

Thanks again, @fenichelar! It's already available in mysql2@canary and soon in the latest version too 🤝