[process][posix]: fix getTerminalMap path construction bug

Author: shirou

process/process_posix.go

@@ -26,7 +26,9 @@ func getTerminalMap() (map[uint64]string, error) {
 	ret := make(map[uint64]string)
 	var termfiles []string
 
-	d, err := os.Open("/dev")
+	devPath := common.HostDev()
+
+	d, err := os.Open(devPath)
 	if err != nil {
 		return nil, err
 	}
@@ -37,32 +39,29 @@ func getTerminalMap() (map[uint64]string, error) {
 		return nil, err
 	}
 	for _, devname := range devnames {
-		if strings.HasPrefix(devname, "/dev/tty") {
-			termfiles = append(termfiles, "/dev/tty/"+devname)
+		if strings.HasPrefix(devname, "tty") {
+			termfiles = append(termfiles, filepath.Join(devPath, devname))
 		}
 	}
 
 	var ptsnames []string
-	ptsd, err := os.Open("/dev/pts")
+	ptsPath := filepath.Join(devPath, "pts")
+	ptsd, err := os.Open(ptsPath)
 	if err != nil {
-		ptsnames, _ = filepath.Glob("/dev/ttyp*")
+		ptsnames, _ = filepath.Glob(filepath.Join(devPath, "ttyp*"))
 		if ptsnames == nil {
 			return nil, err
 		}
-	}
-	defer ptsd.Close()
-
-	if ptsnames == nil {
+		termfiles = append(termfiles, ptsnames...)
+	} else {
 		defer ptsd.Close()
 		ptsnames, err = ptsd.Readdirnames(-1)
 		if err != nil {
 			return nil, err
 		}
 		for _, ptsname := range ptsnames {
-			termfiles = append(termfiles, "/dev/pts/"+ptsname)
+			termfiles = append(termfiles, filepath.Join(ptsPath, ptsname))
 		}
-	} else {
-		termfiles = ptsnames
 	}
 
 	for _, name := range termfiles {
@@ -72,7 +71,7 @@ func getTerminalMap() (map[uint64]string, error) {
 			return nil, err
 		}
 		rdev := uint64(stat.Rdev)
-		ret[rdev] = strings.ReplaceAll(name, "/dev", "")
+		ret[rdev] = strings.TrimPrefix(name, devPath+string(os.PathSeparator))
 	}
 	return ret, nil
 }

process/process_posix_test.go

@@ -9,6 +9,8 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"golang.org/x/sys/unix"
+
+	"github.com/shirou/gopsutil/v4/internal/common"
 )
 
 func Test_SendSignal(t *testing.T) {
@@ -17,3 +19,16 @@ func Test_SendSignal(t *testing.T) {
 	p, _ := NewProcess(int32(checkPid))
 	assert.NoErrorf(t, p.SendSignal(unix.SIGCONT), "send signal")
 }
+
+func TestGetTerminalMapPathsExist(t *testing.T) {
+	termmap, err := getTerminalMap()
+	if err != nil {
+		t.Skipf("getTerminalMap not available: %v", err)
+	}
+
+	for _, name := range termmap {
+		fullPath := common.HostDev(name)
+		_, err := os.Stat(fullPath)
+		assert.NoErrorf(t, err, "terminal device should exist: %s", fullPath)
+	}
+}