Skip to content

always disable the builtin hostname verification - #526

Merged
shazow merged 1 commit into
urllib3:masterfrom
t-8ch:disable_builtin_hostname_verification
Feb 4, 2015
Merged

shazow merged 1 commit into
urllib3:masterfrom
t-8ch:disable_builtin_hostname_verification

Conversation

@t-8ch

@t-8ch t-8ch commented Dec 19, 2014

Copy link
Copy Markdown
Contributor

It conflicts with our own, more flexible functionality

Fixes #524

@t-8ch
t-8ch force-pushed the disable_builtin_hostname_verification branch 2 times, most recently from 8c47d80 to 5a61b61 Compare December 19, 2014 16:46
@t-8ch

t-8ch commented Dec 19, 2014

Copy link
Copy Markdown
Contributor Author

I give up on travis. Tried 3 times and everytime some random timeout or proxy test broke.

@Lukasa

Lukasa commented Dec 20, 2014

Copy link
Copy Markdown
Contributor

LGTM, though we do need a clean test run.

@sigmavirus24

Copy link
Copy Markdown
Contributor

So I'm -1 on this. If I can get some time to work on #507 and move the context logic into that method (like was suggested in the review comments) then this wouldn't be necessary and we'll be able to handle this logic a lot better.

@shazow

shazow commented Dec 23, 2014

Copy link
Copy Markdown
Member

@sigmavirus24 What's your ETA? I'm cool on blocking on your fix if it's soon-ish. :)

@shazow

shazow commented Dec 23, 2014

Copy link
Copy Markdown
Member

@Lukasa Do you think this is urgent enough to push out a 1.10.1 hotfix, or should we wait for @sigmavirus24 to Fix It Properly? :P

@Lukasa

Lukasa commented Dec 24, 2014

Copy link
Copy Markdown
Contributor

Ehh....pass?

The summary is that hostname verification is broken in 1.10, and if you do anything other than the default behaviour the stdlib will ruin your day. Now, it might be enough to publish an advisory that says "hey, 1.10 has this bug in it, please avoid upgrading if you rely on this functionality" and then wait for @sigmavirus24. That way we never have a temporary fix in place.

@shazow

shazow commented Dec 24, 2014

Copy link
Copy Markdown
Member

If only there was some medium to publish such an advisory on that is not my twitter account. :P

@Lukasa

Lukasa commented Dec 24, 2014

Copy link
Copy Markdown
Contributor

Haha, quite.

@alecz20

alecz20 commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

We should also add a test case for this issue. Even if this might not break in the future, a test case would prevent a release if the functionality is broken somewhere else.

It conflicts with our own, more flexible functionality

Fixes urllib3#524
@t-8ch
t-8ch force-pushed the disable_builtin_hostname_verification branch from 5a61b61 to 6340b18 Compare January 8, 2015 18:24
@t-8ch

t-8ch commented Jan 8, 2015

Copy link
Copy Markdown
Contributor Author

There comes a patch.

@sigmavirus24

Copy link
Copy Markdown
Contributor

👍 when the tests pass

@t-8ch t-8ch closed this Feb 4, 2015
@t-8ch t-8ch reopened this Feb 4, 2015
@t-8ch t-8ch closed this Feb 4, 2015
@t-8ch t-8ch reopened this Feb 4, 2015
@t-8ch

t-8ch commented Feb 4, 2015

Copy link
Copy Markdown
Contributor Author

They passed, finally...

@Lukasa

Lukasa commented Feb 4, 2015

Copy link
Copy Markdown
Contributor

LGTM. 👍 🍰

shazow added a commit that referenced this pull request Feb 4, 2015
always disable the builtin hostname verification.
@shazow
shazow merged commit bc8bfdf into urllib3:master Feb 4, 2015
@Yasumoto

Yasumoto commented Feb 7, 2015

Copy link
Copy Markdown

Howdy all,

Any chance you can cut a new release that includes this? I'm relatively sure that we're running into #543 and I'd be willing to pitch in if needed so we can get pip (and thus virtualenv) upgraded.

Thanks!
Joe

@shazow

shazow commented Feb 7, 2015

Copy link
Copy Markdown
Member

@Yasumoto Good call. How about early next week? We have a couple of issues I'd like to get merged and then push out 1.10.1

@Yasumoto

Yasumoto commented Feb 7, 2015

Copy link
Copy Markdown

That sounds awesome! We're pretty far downstream, so much appreciated :)

msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
Changes


2.5.3 (2015-02-24)

Bugfixes

    Revert changes to our vendored certificate bundle. For more context see (#2455, #2456, and http://bugs.python.org/issue23476)

2.5.2 (2015-02-23)

Features and Improvements

    Add sha256 fingerprint support. (urllib3/urllib3#540)
    Improve the performance of headers. (urllib3/urllib3#544)

Bugfixes

    Copy pip’s import machinery. When downstream redistributors remove requests.packages.urllib3 the import machinery will continue to let those same symbols work. Example usage in requests’ documentation and 3rd-party libraries relying on the vendored copies of urllib3 will work without having to fallback to the system urllib3.
    Attempt to quote parts of the URL on redirect if unquoting and then quoting fails. (#2356)
    Fix filename type check for multipart form-data uploads. (#2411)
    Properly handle the case where a server issuing digest authentication challenges provides both auth and auth-int qop-values. (#2408)
    Fix a socket leak. (urllib3/urllib3#549)
    Fix multiple Set-Cookie headers properly. (urllib3/urllib3#534)
    Disable the built-in hostname verification. (urllib3/urllib3#526)
    Fix the behaviour of decoding an exhausted stream. (urllib3/urllib3#535)

Security

    Pulled in an updated cacert.pem.
    Drop RC4 from the default cipher list. (urllib3/urllib3#551)
tsutsui pushed a commit to tsutsui/pkgsrc that referenced this pull request Oct 17, 2026
Changes


2.5.3 (2015-02-24)

Bugfixes

    Revert changes to our vendored certificate bundle. For more context see (#2455, #2456, and http://bugs.python.org/issue23476)

2.5.2 (2015-02-23)

Features and Improvements

    Add sha256 fingerprint support. (urllib3/urllib3#540)
    Improve the performance of headers. (urllib3/urllib3#544)

Bugfixes

    Copy pip’s import machinery. When downstream redistributors remove requests.packages.urllib3 the import machinery will continue to let those same symbols work. Example usage in requests’ documentation and 3rd-party libraries relying on the vendored copies of urllib3 will work without having to fallback to the system urllib3.
    Attempt to quote parts of the URL on redirect if unquoting and then quoting fails. (#2356)
    Fix filename type check for multipart form-data uploads. (#2411)
    Properly handle the case where a server issuing digest authentication challenges provides both auth and auth-int qop-values. (#2408)
    Fix a socket leak. (urllib3/urllib3#549)
    Fix multiple Set-Cookie headers properly. (urllib3/urllib3#534)
    Disable the built-in hostname verification. (urllib3/urllib3#526)
    Fix the behaviour of decoding an exhausted stream. (urllib3/urllib3#535)

Security

    Pulled in an updated cacert.pem.
    Drop RC4 from the default cipher list. (urllib3/urllib3#551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assert_hostname=False seems to be ignored in 1.10

6 participants