Repository navigation
always disable the builtin hostname verification - #526
Conversation
8c47d80 to
5a61b61
Compare
|
I give up on travis. Tried 3 times and everytime some random timeout or proxy test broke. |
|
LGTM, though we do need a clean test run. |
|
So I'm -1 on this. If I can get some time to work on #507 and move the context logic into that method (like was suggested in the review comments) then this wouldn't be necessary and we'll be able to handle this logic a lot better. |
|
@sigmavirus24 What's your ETA? I'm cool on blocking on your fix if it's soon-ish. :) |
|
@Lukasa Do you think this is urgent enough to push out a 1.10.1 hotfix, or should we wait for @sigmavirus24 to Fix It Properly? :P |
|
Ehh....pass? The summary is that hostname verification is broken in 1.10, and if you do anything other than the default behaviour the stdlib will ruin your day. Now, it might be enough to publish an advisory that says "hey, 1.10 has this bug in it, please avoid upgrading if you rely on this functionality" and then wait for @sigmavirus24. That way we never have a temporary fix in place. |
|
If only there was some medium to publish such an advisory on that is not my twitter account. :P |
|
Haha, quite. |
|
We should also add a test case for this issue. Even if this might not break in the future, a test case would prevent a release if the functionality is broken somewhere else. |
It conflicts with our own, more flexible functionality Fixes urllib3#524
5a61b61 to
6340b18
Compare
|
There comes a patch. |
|
👍 when the tests pass |
|
They passed, finally... |
|
LGTM. 👍 🍰 |
always disable the builtin hostname verification.
|
Howdy all, Any chance you can cut a new release that includes this? I'm relatively sure that we're running into #543 and I'd be willing to pitch in if needed so we can get pip (and thus virtualenv) upgraded. Thanks! |
|
@Yasumoto Good call. How about early next week? We have a couple of issues I'd like to get merged and then push out 1.10.1 |
|
That sounds awesome! We're pretty far downstream, so much appreciated :) |
Changes
2.5.3 (2015-02-24)
Bugfixes
Revert changes to our vendored certificate bundle. For more context see (#2455, #2456, and http://bugs.python.org/issue23476)
2.5.2 (2015-02-23)
Features and Improvements
Add sha256 fingerprint support. (urllib3/urllib3#540)
Improve the performance of headers. (urllib3/urllib3#544)
Bugfixes
Copy pip’s import machinery. When downstream redistributors remove requests.packages.urllib3 the import machinery will continue to let those same symbols work. Example usage in requests’ documentation and 3rd-party libraries relying on the vendored copies of urllib3 will work without having to fallback to the system urllib3.
Attempt to quote parts of the URL on redirect if unquoting and then quoting fails. (#2356)
Fix filename type check for multipart form-data uploads. (#2411)
Properly handle the case where a server issuing digest authentication challenges provides both auth and auth-int qop-values. (#2408)
Fix a socket leak. (urllib3/urllib3#549)
Fix multiple Set-Cookie headers properly. (urllib3/urllib3#534)
Disable the built-in hostname verification. (urllib3/urllib3#526)
Fix the behaviour of decoding an exhausted stream. (urllib3/urllib3#535)
Security
Pulled in an updated cacert.pem.
Drop RC4 from the default cipher list. (urllib3/urllib3#551)
Changes
2.5.3 (2015-02-24)
Bugfixes
Revert changes to our vendored certificate bundle. For more context see (#2455, #2456, and http://bugs.python.org/issue23476)
2.5.2 (2015-02-23)
Features and Improvements
Add sha256 fingerprint support. (urllib3/urllib3#540)
Improve the performance of headers. (urllib3/urllib3#544)
Bugfixes
Copy pip’s import machinery. When downstream redistributors remove requests.packages.urllib3 the import machinery will continue to let those same symbols work. Example usage in requests’ documentation and 3rd-party libraries relying on the vendored copies of urllib3 will work without having to fallback to the system urllib3.
Attempt to quote parts of the URL on redirect if unquoting and then quoting fails. (#2356)
Fix filename type check for multipart form-data uploads. (#2411)
Properly handle the case where a server issuing digest authentication challenges provides both auth and auth-int qop-values. (#2408)
Fix a socket leak. (urllib3/urllib3#549)
Fix multiple Set-Cookie headers properly. (urllib3/urllib3#534)
Disable the built-in hostname verification. (urllib3/urllib3#526)
Fix the behaviour of decoding an exhausted stream. (urllib3/urllib3#535)
Security
Pulled in an updated cacert.pem.
Drop RC4 from the default cipher list. (urllib3/urllib3#551)
It conflicts with our own, more flexible functionality
Fixes #524