-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add 'c' parameter to 'less' command #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Probably it could be worth mentioning this at https://github.com/sharkdp/bat?tab=readme-ov-file#using-less-as-a-pager |
|
Hello, |
|
this is a minefield, we fix a bug for someone we introduce a bug for someone else can we write a regression test for your use case_ that we will at least not break it in the future if this turns out to be problematic and we found other solutions I don't fully understand the problem, it would be helpful if you could elaborate |
What bugs are you referring to ?
Sure.
I provided an explanation with an attached GIF there : #2912 (comment) |
|
I'm not referring to specific bugs but to the risk of introducing bugs by changing behavior. But if we (with "we" I really mean "you" ;) add a regression test for this case, that's fine. Then it's up to those who depend on the current behavior to fix any follow-up bugs and write regression tests for their uses cases. I can reproduce the problem with this btw:
Expected result: Actual result: |
Oh 😅 I don't how to do that lol I don't do Rust, but even if I did or if this was a JS project (that's the one language I'm fluent at), I actually don't see how this could be checked, as it's not just manipulating strings, but checking scroll (and text-based scroll sounds even harder than web scroll) ? |
|
For the record, if you are comfortable to merge this without a regression test @keith-hall, that's fine with me! (I noticed your PR Approval still stands.) |
|
Closing for now to keep PR inbox clean but am of course happy to re-open if you get around writing a test. |
|
Well, you pinged someone about merging this without a test, and they never responded 😭 Plus, I also said I wouldn't know how to do that 😭 |
As per #2912 (reply in thread)