Skip to content

Commit ab4e5ed

Browse files
authored
Merge pull request #2815 from dtolnay-contrib/derive
Eliminate dependency on serde's "derive" feature
2 parents 95993cf + 1a54c9b commit ab4e5ed

File tree

6 files changed

+24
-24
lines changed

6 files changed

+24
-24
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
- [BREAKING] `SyntaxMapping::{empty,builtin}` are removed; use `SyntaxMapping::new` instead
3636
- [BREAKING] `SyntaxMapping::mappings` is replaced by `SyntaxMapping::{builtin,custom,all}_mappings`
3737
- Make `Controller::run_with_error_handler`'s error handler `FnMut`, see #2831 (@rhysd)
38+
- Improve compile time by 20%, see #2815 (@dtolnay)
3839

3940
# v0.24.0
4041

Cargo.lock

Lines changed: 13 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ content_inspector = "0.2.4"
5353
shell-words = { version = "1.1.0", optional = true }
5454
unicode-width = "0.1.11"
5555
globset = "0.4"
56-
serde = { version = "1.0", features = ["derive"] }
56+
serde = "1.0"
57+
serde_derive = "1.0"
5758
serde_yaml = "0.9.28"
5859
semver = "1.0"
5960
path_abs = { version = "0.5", default-features = false }
@@ -74,7 +75,7 @@ optional = true
7475
default-features = false
7576

7677
[dependencies.syntect]
77-
version = "5.1.0"
78+
version = "5.2.0"
7879
default-features = false
7980
features = ["parsing"]
8081

@@ -94,6 +95,7 @@ serial_test = { version = "2.0.0", default-features = false }
9495
predicates = "3.0.4"
9596
wait-timeout = "0.2.0"
9697
tempfile = "3.8.1"
98+
serde = { version = "1.0", features = ["derive"] }
9799

98100
[target.'cfg(unix)'.dev-dependencies]
99101
nix = { version = "0.26.4", default-features = false, features = ["term"] }
@@ -104,8 +106,9 @@ indexmap = { version = "2.2.2", features = ["serde"] }
104106
itertools = "0.11.0"
105107
once_cell = "1.18"
106108
regex = "1.10.2"
107-
serde = { version = "1.0", features = ["derive"] }
108-
serde_with = { version = "3.4.0", default-features = false, features = ["macros"] }
109+
serde = "1.0"
110+
serde_derive = "1.0"
111+
serde_with = { version = "3.6.1", default-features = false, features = ["macros"] }
109112
toml = { version = "0.8.9", features = ["preserve_order"] }
110113
walkdir = "2.4"
111114

build/syntax_mapping.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use indexmap::IndexMap;
1010
use itertools::Itertools;
1111
use once_cell::sync::Lazy;
1212
use regex::Regex;
13-
use serde::Deserialize;
13+
use serde_derive::Deserialize;
1414
use serde_with::DeserializeFromStr;
1515
use walkdir::WalkDir;
1616

src/assets/assets_metadata.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std::path::Path;
33
use std::time::SystemTime;
44

55
use semver::Version;
6-
use serde::{Deserialize, Serialize};
6+
use serde_derive::{Deserialize, Serialize};
77

88
use crate::error::*;
99

src/assets/lazy_theme_set.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ use super::*;
33
use std::collections::BTreeMap;
44
use std::convert::TryFrom;
55

6-
use serde::Deserialize;
7-
use serde::Serialize;
6+
use serde_derive::{Deserialize, Serialize};
87

98
use once_cell::unsync::OnceCell;
109

0 commit comments

Comments
 (0)