Skip to content

Conversation

@samzong
Copy link

@samzong samzong commented Jul 24, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #168

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @samzong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've significantly expanded the documentation for OME, focusing on how models are managed and stored, particularly with Persistent Volume Claims (PVCs). This update introduces detailed architectural explanations, a comprehensive reference for all supported storage types, and practical user guides. The goal is to provide clear, in-depth information for users and developers on leveraging various storage backends, ensuring they can efficiently manage and serve models within the OME ecosystem.

Highlights

  • New PVC Storage Architecture Documentation: I've added comprehensive documentation detailing the architecture and data flow for using Persistent Volume Claims (PVCs) as a storage backend for models in OME. This explains how PVCs are handled differently from other storage types, bypassing the model agent and leveraging native Kubernetes volume management.
  • Comprehensive Storage Types Reference: I've introduced a new, exhaustive reference guide for all supported storage types within OME, including PVC, OCI Object Storage, HuggingFace Hub, AWS S3, Azure Blob, Google Cloud Storage, GitHub Releases, and custom Vendor Storage. This guide covers URI formats, authentication, examples, and selection criteria for each.
  • Dedicated PVC Storage Troubleshooting Guide: I've created a dedicated troubleshooting guide for common issues encountered when using PVC storage with OME models. This guide provides symptoms, causes, solutions, and diagnostic tools to help users resolve problems efficiently.
  • New User Guide for PVC Storage Configuration: I've added a user-focused guide on how to configure and utilize PVC storage for models, including step-by-step instructions, examples for different access modes, and best practices for performance and security.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds extensive documentation for using PVC storage and managing models in OME. The new documentation is well-structured and comprehensive, covering architecture, user guides, reference material, and troubleshooting. My review focuses on improving the correctness and consistency of the examples and diagnostic scripts. I've identified a bug in the troubleshooting scripts that would cause them to fail for ClusterBaseModels, an incomplete credential configuration in a migration example, and some minor inconsistencies in model names and formatting across the new documents. Overall, this is a great addition to the project's documentation.

@samzong samzong force-pushed the docs-for-pvc branch 2 times, most recently from 624546a to fd26bbc Compare July 25, 2025 01:56
@samzong samzong marked this pull request as ready for review July 25, 2025 02:50
@samzong samzong requested a review from slin1237 as a code owner July 25, 2025 02:50
@samzong
Copy link
Author

samzong commented Jul 25, 2025

@slin1237 I finished the first version of this PR, there should be many problems, hope to get everyone's Review.

Copy link
Collaborator

@slin1237 slin1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving other comments

@samzong
Copy link
Author

samzong commented Nov 17, 2025

@slin1237 sorry for late (toooooooo), I have fix all comments.

Hope it's not too late.

@samzong samzong requested a review from slin1237 November 17, 2025 16:18
@samzong
Copy link
Author

samzong commented Nov 17, 2025

/gemini review

In accordance with the issue of #168

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive documentation for PVC storage and model management, covering architecture, user guides, and troubleshooting. It also integrates Mermaid.js for rendering diagrams in the documentation. The new documentation is well-structured and provides clear examples for various use cases. The Mermaid integration is a valuable addition for visual explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task 8: Documentation

2 participants