Issue #2677: Autocomplete fields duplicated when using browser back/forward buttons#2678
Merged
mshibuya merged 2 commits intoSep 3, 2016
Merged
Conversation
Author
|
CI failing due to Rubocop issues addressed in PR 2679 |
added 2 commits
July 29, 2016 15:52
…owser back/forward buttons When accessing the add or edit page for a model that uses the ui-autocomplete fields, using the back and forward buttons on the browser can cause the autocomplete fields to be duplicated.
Ensure Javascript all conforms to standards. Remove unnecessary whitespace but add whitespace where it makes long strings easier to read.
HashNotAdam
force-pushed
the
hotfix/fix_duplication_bug
branch
from
49b9429 to
5da6a54
Compare
Member
|
Works fine, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accessing the add or edit page for a model that uses the ui-autocomplete fields, using the back and forward buttons on the browser can cause the autocomplete fields to be duplicated.
In _create, check if the field exists before creating it but still initialise autocomplete and set any necessary event handlers.
Also break out the Javascript into multiple, much smaller, functions so it is easier to follow. Since the Asset Pipeline can be used for magnification, we can afford to increase file size to increase readability. Who knows, the file may even get tested one day too.