Pundit Integration

[jayasi]

Integration of the Pundit gem. #2120

• (Team CodeBenders, RGSoC'15)

[sferik]

@jayasi The tests are failing on Travis CI? The problem appears to be:

/home/travis/build/sferik/rails_admin/spec/spec_helper.rb:9:in `require': cannot load such file -- pundit/rspec (LoadError)

Can you please look into fixing that?

[mshibuya]

Version-specific Gemfiles under gemfiles/* also need to be updated, running

$ appraisal install

will do the job.

[mshibuya]

This makes Pundit required dependency, we should make it optional choice.

[jayasi]

@sferik, @mshibuya Thank you for your feedback. Have made changes accordingly.

[mshibuya]

How about this issue?
We really need to get rid of this ugly case-when chain.

[jayasi]

@sferik, @mshibuya, I've removed the need for the case-when chain by modifying the authorization adapter.

The CI test that is failing is for Ruby 2.2, but I am unable to reproduce it locally. I tried
BUNDLE_GEMFILE=/Users/jayasimehar/Desktop/rails_admin/gemfiles/rails_4.2.gemfile

CI_ORM=mongoid

bundle exec rspec ./spec/integration/config/edit/rails_admin_config_edit_spec.rb

And all tests are passing.

[mshibuya]

Merged in 🔨
Thanks so much, @Team-CodeBenders ❤️

[mshibuya]

@jayasi @meghaarora42 Additionally, you may be interested in creating Wiki entry, which will promote use of this change.

[jayasi]

@mshibuya Thank you 😄

We will create the wiki entry.

[meghaarora42]

@mshibuya Thank you for all the help! :D

[dalpo]

Thank you Rails Girls!!! 👏 👏 👏

[kgrz]

👏🏼

[ronen]

Do you have a timeline for a (minor) release that includes this? I've already started using rails_admin with pundit (:clap: :clap: :clap:), but I'd rather not install from master branch. Thanks!

[md5]

@jayasi Did you ever create a wiki entry for this? I'm not seeing one.

I'm wondering how access to the RailsAdmin dashboard is supposed to be authorized. I'm seeing RailsAdmin trying to call dashboard? on an ApplicationPolicy instance with policy.record = nil. It seems like it should be getting a RailsAdminPolicy with Pundit.policy(current_user, :rails_admin) and calling dashboard? on that.

Some guidance on how to use the :pundit authorization method would be appreciated.

[md5]

I also see it trying to call history? on my model's policies when paper_trail integration is enabled.

[mxmzb]

+1 would appreciate a wiki on this.

PS.: I liked the nested approach more, it gave you more power: bf63d68

[aeons]

Anyone figured out how to use this?

[tquill]

Any time frame for updating the documentation on this?

[masciugo]

a wiki is of course needed but in the meantime ... https://github.com/sferik/rails_admin/blob/ba2088c6ecabd354b4b67c50bb00fccdbd1e6240/spec/integration/authorization/pundit_spec.rb

[mxmzb]

Since rails_admin 1.0 stable (worked in rc1) I am getting an undefined method 'policy' for #<RailsAdmin::MainController:0x007fcffdaf1c28> with Pundit integration.