Replace jQueryUI datetimepicker with jQuery Bootstrap datetimepicker by dalpo · Pull Request #2391 · railsadminteam/rails_admin

dalpo · 2015-08-26T00:17:14Z

Refactor Datetime, Date and Time type inputs
Replace jquery ui datepicker with https://eonasdan.github.io/bootstrap-datetimepicker/
Refactor Datetime, Date and Time search filters

dalpo · 2015-08-26T07:35:49Z

WIP: I'm fixing failing specs

dalpo · 2015-09-04T16:03:38Z

The failing specs about mongoid are related to DatabaseCleaner/database_cleaner#385

mshibuya · 2015-09-05T08:44:07Z

This is incompatible change, please state that in changelog.

Changelog updated! 😃

Let me know if you have more feedback.
Thanks!

dalpo · 2015-09-05T10:43:57Z

Some screenshots:

dalpo · 2015-09-05T13:08:31Z

Everythink is Green! 🎆

@mshibuya, @sferik (or anyone else) could you review this PR an let me know what do you think about it?

mshibuya · 2015-09-07T14:05:47Z

This message is useless for non-Mongoid users.
Can't we just go without requiring mongoid here?

You are right, we can remove it.

Replace jQueryUI datetimepicker with jQuery Bootstrap datetimepicker

mshibuya · 2015-09-11T13:42:37Z

Great thanks for your effort! 😃

fmh · 2015-09-11T16:11:38Z

Good job 👍, but have this error :

No such file to load -- rails_admin/i18n_support

dalpo · 2015-09-11T16:14:10Z

Thanks guys 😄

@fmh Could you paste the stack trace?

fmh · 2015-09-11T16:31:02Z

skip it, it's my old application_helper file 😊.

dalpo · 2015-09-11T17:34:24Z

Don't worry 😉

Let me know if you find some other kind of issue!

fmh · 2015-09-12T10:31:34Z

@dalpo thx for this feature ,
After some tests, I noticed some visual adjustments to make. look at the screenshots :

date widget : very large in filter form
time widget : I can not display it in filter form (need to handle time type in filter_box) , very large in all forms
time widget : cannot filter with time field.

- in modal form : maybe some css settings to correct the display

I try to send a PR until tomorrow.

Sorry for my English 😊 🇬🇧

dalpo · 2015-09-12T16:24:30Z

Could you try with a vanilla rails_admin installation, without css customization?

fmh · 2015-09-12T17:15:41Z

this work fine 😳😳😳, but still can not filter with time field and time widget very large

it will be better a little small (original bootstrap plugin have this size)

dalpo · 2015-09-13T13:48:26Z

Thanks @fmh, you are right!

I'm going to check the following issues soon:

Better html markup for time input
Check time field filters

BTW I have a question...
What kind of database datatype are you using to store HH:mm values?

fmh · 2015-09-13T14:30:46Z

DataType : Time
Rails Timezone: Bern
DB (mysql) Timezone : default

dalpo · 2015-09-23T11:23:53Z

@fmh I opened a new PR #2408

SuperMasterBlasterLaser · 2015-12-10T08:40:55Z

@dalpo Filtering by time only works when language is set to english. When I switched locale to russian, it does not filter by date and between. It just shows all available models in database.

I used Mongoid. Don't know if it is happening on AR.

dalpo force-pushed the feature/bs-datetime-picker branch 2 times, most recently from 33fe95b to 8c593bc Compare August 26, 2015 07:23

dalpo mentioned this pull request Aug 26, 2015

Replacing the datepicker with bootstrap-datepicker #1551

Closed

dalpo force-pushed the feature/bs-datetime-picker branch 3 times, most recently from 6fe5b3c to d7b62a8 Compare September 4, 2015 08:45

dalpo changed the title ~~Replace old jQuery UI datetime picker with jQuery Bootstrap datetimepicker~~ Replace jQueryUI datetime picker with jQuery Bootstrap datetimepicker Sep 4, 2015

dalpo changed the title ~~Replace jQueryUI datetime picker with jQuery Bootstrap datetimepicker~~ Replace jQueryUI datetimepicker with jQuery Bootstrap datetimepicker Sep 4, 2015

mshibuya reviewed Sep 5, 2015
View reviewed changes

dalpo added 19 commits September 5, 2015 12:38

Add jquery bootstrap datetimepicker

d0e64fe

Fix: use font awesome icons

6a90c39

Move I18n rails_admin suppurt into a proper directory

d85494c

Change: make accessible current locale to javascript

496388a

Change: initialize new datetimepicker

7cc7c60

Change: move datetime parse logic into a separate file

72c2033

Fix specs

ffb962f

datetime input markup

c3e0851

Fix: allow search date into index action using datepicker

ef2a86a

Drop old jquery ui datepicker assets

af54c8e

Fix mongoid specs

abe3025

Update changelog

63cca16

Change: add #parse_value method into every field class

29e22a5

Refactor date and datetime input fields logic

fe2899f

Move filters render logic into helpers

705fc84

Fix: Mongoid abstract model parsed values

47bf30c

Revert minimum_coverage

b48cd26

Fix: mongoid dependecy load

068b7fd

Fix: new search filters initialization

cd23e23

Fix: Rubocop offences

824edb6

dalpo force-pushed the feature/bs-datetime-picker branch from 06a2ef0 to d2d0ddf Compare September 5, 2015 10:38

dalpo added 2 commits September 5, 2015 12:48

Update changelog

8671927

Change: replace deprecated RSpec stub syntax

7d87bfb

dalpo force-pushed the feature/bs-datetime-picker branch from d2d0ddf to 7d87bfb Compare September 5, 2015 10:56

mshibuya reviewed Sep 7, 2015
View reviewed changes

Remove useless require mongoid directive

cee8a5a

mshibuya added a commit that referenced this pull request Sep 11, 2015

Merge pull request #2391 from dalpo/feature/bs-datetime-picker

50d6e59

Replace jQueryUI datetimepicker with jQuery Bootstrap datetimepicker

mshibuya merged commit 50d6e59 into railsadminteam:master Sep 11, 2015

mshibuya mentioned this pull request Sep 19, 2015

Fix issue #2155 #2396

Closed

dalpo mentioned this pull request Sep 22, 2015

Better time field support #2408

Closed

dalpo mentioned this pull request Oct 10, 2015

Added spec for datetime field #2426

Closed

This was referenced Nov 3, 2015

fix datetime picker #2039

Closed

Fix time offset #2043

Closed

This was referenced Nov 23, 2015

Sass::SyntaxError in RailsAdmin::Main#dashboard with 0.8 #2481

Closed

Add 'vendor' directory to gemspec #2482

Merged

Conversation

dalpo commented Aug 26, 2015

Uh oh!

dalpo commented Aug 26, 2015

Uh oh!

dalpo commented Sep 4, 2015

Uh oh!

mshibuya Sep 5, 2015

Choose a reason for hiding this comment

Uh oh!

dalpo Sep 5, 2015

Choose a reason for hiding this comment

Uh oh!

dalpo commented Sep 5, 2015

Uh oh!

dalpo commented Sep 5, 2015

Uh oh!

mshibuya Sep 7, 2015

Choose a reason for hiding this comment

Uh oh!

dalpo Sep 7, 2015

Choose a reason for hiding this comment

Uh oh!

mshibuya commented Sep 11, 2015

Uh oh!

fmh commented Sep 11, 2015

Uh oh!

dalpo commented Sep 11, 2015

Uh oh!

fmh commented Sep 11, 2015

Uh oh!

dalpo commented Sep 11, 2015

Uh oh!

fmh commented Sep 12, 2015

Uh oh!

dalpo commented Sep 12, 2015

Uh oh!

fmh commented Sep 12, 2015

Uh oh!

dalpo commented Sep 13, 2015

Uh oh!

fmh commented Sep 13, 2015

Uh oh!

dalpo commented Sep 23, 2015

Uh oh!

SuperMasterBlasterLaser commented Dec 10, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants