Allows the user to implement the logic for identity object creation#234
Draft
msabansal wants to merge 1 commit intorust-native-tls:mainfrom
Draft
Allows the user to implement the logic for identity object creation#234msabansal wants to merge 1 commit intorust-native-tls:mainfrom
msabansal wants to merge 1 commit intorust-native-tls:mainfrom
Conversation
Collaborator
|
I do not want to expose the underlying implementing crates to the user. |
Author
|
While I understand the reasoning for it designing a cross platform feature for something thats an abstraction over the underlay feels non trivial. If it is acceptable we can hide this behind a feature flag |
Collaborator
|
It is absolutely nontrivial, but that is what this library is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to whats mentioned in #232 we have a scenario where we want to use certificates which are non-exportable.
Coming up with a clean cross platform design is challenging. This is our attempt to keep things simple and delegate the complexity to the user