Skip to content

Commit 858b6db

Browse files
authored
Revert "Add canonical CEL support: dev.cel.expr (cncf#75)"
This reverts commit 0f5e0d9.
1 parent 0f5e0d9 commit 858b6db

File tree

7 files changed

+53
-134
lines changed

7 files changed

+53
-134
lines changed

bazel/external_proto_deps.bzl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,10 @@ EXTERNAL_PROTO_GO_BAZEL_DEP_MAP = {
2929
# go_googleapis in https://github.com/bazelbuild/rules_go/blob/master/go/dependencies.rst#overriding-dependencies
3030
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto": "@go_googleapis//google/api/expr/v1alpha1:expr_go_proto",
3131
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto": "@go_googleapis//google/api/expr/v1alpha1:expr_go_proto",
32-
"@dev_cel//proto/cel/expr:checked_proto": "@dev_cel//proto/cel/expr:checked_go_proto",
33-
"@dev_cel//proto/cel/expr:syntax_proto": "@dev_cel//proto/cel/expr:syntax_go_proto",
3432
}
3533

3634
# This maps from the Bazel proto_library target to the C++ language binding target for external dependencies.
3735
EXTERNAL_PROTO_CC_BAZEL_DEP_MAP = {
3836
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto": "@com_google_googleapis//google/api/expr/v1alpha1:checked_cc_proto",
3937
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto": "@com_google_googleapis//google/api/expr/v1alpha1:syntax_cc_proto",
40-
"@dev_cel//proto/cel/expr:checked_proto": "@dev_cel//proto/cel/expr:checked_cc_proto",
41-
"@dev_cel//proto/cel/expr:syntax_proto": "@dev_cel//proto/cel/expr:syntax_cc_proto",
4238
}

bazel/repositories.bzl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ def xds_api_dependencies():
2222
"com_google_protobuf",
2323
locations = REPOSITORY_LOCATIONS,
2424
)
25-
xds_http_archive(
26-
name = "dev_cel",
27-
locations = REPOSITORY_LOCATIONS,
28-
)
2925
xds_http_archive(
3026
"io_bazel_rules_go",
3127
locations = REPOSITORY_LOCATIONS,

bazel/repository_locations.bzl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ REPOSITORY_LOCATIONS = dict(
2828
strip_prefix = "protobuf-3.21.5",
2929
urls = ["https://github.com/protocolbuffers/protobuf/archive/v3.21.5.zip"],
3030
),
31-
dev_cel = dict(
32-
sha256 = "6d4bf5a0ac04b35c421cb8317cd35bbe78aacffee787bc7aa89daa1e211ff6be",
33-
strip_prefix = "cel-spec-0.13.0",
34-
urls = ["https://github.com/google/cel-spec/archive/refs/tags/v0.13.0.tar.gz"],
35-
),
3631
io_bazel_rules_go = dict(
3732
sha256 = "6dc2da7ab4cf5d7bfc7c949776b1b7c733f05e56edc4bcd9022bb249d2e2a996",
3833
urls = [

go/xds/type/v3/cel.pb.go

Lines changed: 43 additions & 79 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

go/xds/type/v3/cel.pb.validate.go

Lines changed: 6 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

xds/type/v3/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,5 @@ xds_proto_package(
77
"//xds/annotations/v3:pkg",
88
"@com_google_googleapis//google/api/expr/v1alpha1:checked_proto",
99
"@com_google_googleapis//google/api/expr/v1alpha1:syntax_proto",
10-
"@dev_cel//proto/cel/expr:checked_proto",
11-
"@dev_cel//proto/cel/expr:syntax_proto",
1210
],
1311
)

xds/type/v3/cel.proto

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ package xds.type.v3;
44

55
import "google/api/expr/v1alpha1/checked.proto";
66
import "google/api/expr/v1alpha1/syntax.proto";
7-
import "cel/expr/checked.proto";
8-
import "cel/expr/syntax.proto";
97
import "google/protobuf/wrappers.proto";
108

119
import "xds/annotations/v3/status.proto";
@@ -25,28 +23,14 @@ option (xds.annotations.v3.file_status).work_in_progress = true;
2523
// <https://github.com/google/cel-spec>`_ (CEL) program.
2624
message CelExpression {
2725
oneof expr_specifier {
26+
option (validate.required) = true;
27+
2828
// Parsed expression in abstract syntax tree (AST) form.
29-
//
30-
// Deprecated -- use ``cel_expr_parsed`` field instead.
31-
// If ``cel_expr_parsed`` or ``cel_expr_checked`` is set, this field is not used.
32-
google.api.expr.v1alpha1.ParsedExpr parsed_expr = 1 [deprecated = true];
29+
google.api.expr.v1alpha1.ParsedExpr parsed_expr = 1;
3330

3431
// Parsed expression in abstract syntax tree (AST) form that has been successfully type checked.
35-
//
36-
// Deprecated -- use ``cel_expr_checked`` field instead.
37-
// If ``cel_expr_parsed`` or ``cel_expr_checked`` is set, this field is not used.
38-
google.api.expr.v1alpha1.CheckedExpr checked_expr = 2 [deprecated = true];
32+
google.api.expr.v1alpha1.CheckedExpr checked_expr = 2;
3933
}
40-
41-
// Parsed expression in abstract syntax tree (AST) form.
42-
//
43-
// If ``cel_expr_checked`` is set, this field is not used.
44-
cel.expr.ParsedExpr cel_expr_parsed = 3;
45-
46-
// Parsed expression in abstract syntax tree (AST) form that has been successfully type checked.
47-
//
48-
// If set, takes precedence over ``cel_expr_parsed``.
49-
cel.expr.CheckedExpr cel_expr_checked = 4;
5034
}
5135

5236
// Extracts a string by evaluating a `Common Expression Language

0 commit comments

Comments
 (0)