Use Error::invalid_length instead of a custom error function

Author: sgued

src/bytearray.rs

@@ -9,36 +9,6 @@ use core::ops::{Deref, DerefMut};
 use serde::de::{Deserialize, Deserializer, Error, SeqAccess, Visitor};
 use serde::ser::{Serialize, Serializer};
 
-#[cfg(any(feature = "alloc", feature = "std"))]
-fn error_string(expected: usize, got: usize) -> impl AsRef<str> {
-    #[cfg(not(feature = "std"))]
-    let res = alloc::format!("Expected {} bytes, got {}", expected, got);
-
-    #[cfg(feature = "std")]
-    let res = format!("Expected {} bytes, got {}", expected, got);
-    res
-}
-
-#[cfg(all(not(feature = "alloc"), not(feature = "std")))]
-fn error_string(_expected: usize, _got: usize) -> impl AsRef<str> {
-    "Expected a fixed amount of bytes, got a different amount"
-}
-
-#[cfg(any(feature = "alloc", feature = "std"))]
-fn error_string_more(expected: usize) -> impl AsRef<str> {
-    #[cfg(not(feature = "std"))]
-    let res = alloc::format!("Got more than the expected {} bytes", expected);
-
-    #[cfg(feature = "std")]
-    let res = format!("Got more than the expected {} bytes", expected);
-    res
-}
-
-#[cfg(all(not(feature = "alloc"), not(feature = "std")))]
-fn error_string_more(_expected: usize) -> impl AsRef<str> {
-    "Got more than the expected number of bytes"
-}
-
 /// Wrapper around `[u8; N]` to serialize and deserialize efficiently.
 ///
 /// ```
@@ -219,15 +189,15 @@ impl<'de, const N: usize> Visitor<'de> for ByteArrayVisitor<N> {
         let mut idx = 0;
         while let Some(b) = visitor.next_element()? {
             if idx >= N {
-                return Err(V::Error::custom(error_string_more(N).as_ref()));
+                return Err(V::Error::invalid_length(N, &self));
             }
 
             bytes[idx] = b;
             idx += 1;
         }
 
         if idx != N {
-            return Err(V::Error::custom(error_string(N, idx).as_ref()));
+            return Err(V::Error::invalid_length(N, &self));
         }
 
         Ok(ByteArray::from(bytes))
@@ -240,7 +210,7 @@ impl<'de, const N: usize> Visitor<'de> for ByteArrayVisitor<N> {
         Ok(ByteArray {
             bytes: v
                 .try_into()
-                .map_err(|_| E::custom(error_string(N, v.len()).as_ref()))?,
+                .map_err(|_| E::invalid_length(v.len(), &self))?,
         })
     }
 
@@ -252,7 +222,7 @@ impl<'de, const N: usize> Visitor<'de> for ByteArrayVisitor<N> {
             bytes: v
                 .as_bytes()
                 .try_into()
-                .map_err(|_| E::custom(error_string(N, v.len()).as_ref()))?,
+                .map_err(|_| E::invalid_length(v.len(), &self))?,
         })
     }
 }